git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH v2] t/: migrate helper/test-oidtree.c to unit-tests/t-oidtree.c

From
Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Date
Jun 10, 2024, 20:52 UTC
Message-ID
<72dncmhj2qt6ufh67gbj3ctnwnssnlc3w22x77chcigzxou36f@mnwnrwg4oo5r>
In-Reply-To
<xmqqed944uq7.fsf@gitster.g>
On Mon, 10 Jun 2024, Junio C Hamano <gitster@pobox.com> wrote:
Show 12 quoted lines
> Ghanshyam Thakkar <shyamthakkar001@gmail.com> writes:
> 
> > helper/test-oidtree.c along with t0069-oidtree.sh test the oidtree.h
> > library, which is a wrapper around crit-bit tree. Migrate them to
> > the unit testing framework for better debugging and runtime
> > performance. Along with the migration, add an extra check for
> > oidtree_each() test, which showcases how multiple expected matches can
> > be given to check_each() helper.
> > ...
> 
> Use "LAST_ARG_MUST_BE_NULL" here, probably.
> > +static void check_each(struct oidtree *ot, char *query, ...)

I see that you already made this change in merge-fix/gt/unit-test-oidtree. Thanks for that.

Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 14 in “t/: migrate helper/test-oidtree.c to unit-tests/t-oidtree.c”
  1. Ghanshyam ThakkarJun 5, 2024
  2. Junio C HamanoJun 6, 2024
  3. Ghanshyam ThakkarJun 6, 2024
  4. Christian CouderJun 7, 2024
  5. Christian CouderJun 7, 2024
  6. Christian CouderJun 7, 2024
  7. Junio C HamanoJun 7, 2024
  8. [GSoC][PATCH v2] t/: migrate helper/test-oidtree.c to unit-tests/t-oidtree.cGhanshyam Thakkar, Jun 8, 2024
  9. Junio C HamanoJun 10, 2024
  10. Ghanshyam ThakkarJun 10, 2024
  11. Junio C HamanoJun 10, 2024
  12. Ghanshyam ThakkarJun 10, 2024
  13. Junio C HamanoJun 10, 2024
  14. Ghanshyam ThakkarJun 10, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.