Re: [GSoC][PATCH v2] t/: migrate helper/test-oidtree.c to unit-tests/t-oidtree.c
- From
Ghanshyam Thakkar <shyamthakkar001@gmail.com>
- Date
- Jun 10, 2024, 20:52 UTC
- Message-ID
- <72dncmhj2qt6ufh67gbj3ctnwnssnlc3w22x77chcigzxou36f@mnwnrwg4oo5r>
- In-Reply-To
- <xmqqed944uq7.fsf@gitster.g>
On Mon, 10 Jun 2024, Junio C Hamano <gitster@pobox.com> wrote:
Show 12 quoted lines
> Ghanshyam Thakkar <shyamthakkar001@gmail.com> writes: > > > helper/test-oidtree.c along with t0069-oidtree.sh test the oidtree.h > > library, which is a wrapper around crit-bit tree. Migrate them to > > the unit testing framework for better debugging and runtime > > performance. Along with the migration, add an extra check for > > oidtree_each() test, which showcases how multiple expected matches can > > be given to check_each() helper. > > ... > > Use "LAST_ARG_MUST_BE_NULL" here, probably. > > +static void check_each(struct oidtree *ot, char *query, ...)
I see that you already made this change in merge-fix/gt/unit-test-oidtree. Thanks for that.