Re: [PATCH v2] http: add custom hostname to IP address resolutions

From: Christian Couder <christian.couder@gmail.com>
Date: May 12, 2022, 08:52 UTC
Message-ID: <CAP8UFD3UvjJzEQApiCKSknDWaTjbEMKkr17j1QN-8gwz7eWV3Q@mail.gmail.com>
In-Reply-To: <20220505112114.ktki3dgjbyukzhlm@carlos-mbp.lan>

On Thu, May 5, 2022 at 1:21 PM Carlo Marcelo Arenas Belón <carenas@gmail.com> wrote:

Show 16 quoted lines

>
> On Wed, May 04, 2022 at 12:46:01PM +0200, Christian Couder wrote:
> > diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
> > index f92c79c132..d97380be87 100755
> > --- a/t/t5551-http-fetch-smart.sh
> > +++ b/t/t5551-http-fetch-smart.sh
> > @@ -567,4 +567,11 @@ test_expect_success 'client falls back from v2 to v0 to match server' '
> >       grep symref=HEAD:refs/heads/ trace
> >  '
> >
> > +test_expect_success 'passing hostname resolution information works' '
> > +     BOGUS_HOST=gitbogusexamplehost.com &&
>
> minor nitpick, but better to use example.com here which is reserved for this
> type of uses and therefore unlikely to conflict with a possibly assigned
> domain.

Sorry for not replying to this earlier, but Junio previously suggested the following:

"Perhaps invent a totally bogus domain name, map that to localhost ::1, run a test server locally, and try to clone from that bogus domain?"

(See: https://lore.kernel.org/git/xmqqfslrycvp.fsf@gitster.g/)

I think "a totally bogus domain name" refers to something other than "example.com".

Also "example.com" does seem to resolve to an IP address and even has an HTTP(S) server on it, while I think the purpose of the test would be to check that there is not even a valid DNS resolution when the new option is not used.