Re: [PATCH v2] http: add custom hostname to IP address resolutions

From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date: May 5, 2022, 11:21 UTC
Message-ID: <20220505112114.ktki3dgjbyukzhlm@carlos-mbp.lan>
In-Reply-To: <20220504104601.136403-1-chriscool@tuxfamily.org>

On Wed, May 04, 2022 at 12:46:01PM +0200, Christian Couder wrote:

Show 10 quoted lines

> diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
> index f92c79c132..d97380be87 100755
> --- a/t/t5551-http-fetch-smart.sh
> +++ b/t/t5551-http-fetch-smart.sh
> @@ -567,4 +567,11 @@ test_expect_success 'client falls back from v2 to v0 to match server' '
>  	grep symref=HEAD:refs/heads/ trace
>  '
>  
> +test_expect_success 'passing hostname resolution information works' '
> +	BOGUS_HOST=gitbogusexamplehost.com &&

minor nitpick, but better to use example.com here which is reserved for this type of uses and therefore unlikely to conflict with a possibly assigned domain.

Carlo