git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/1] *** EDITED add.c ***

From
Christian Couder <christian.couder@gmail.com>
Date
Oct 9, 2023, 08:03 UTC
Message-ID
<CAP8UFD3Cj7nC704Rti8jBp6VxBJDxsBpf_8vvordW8MWXc_GDA@mail.gmail.com>
In-Reply-To
<CACS=G2xfUYVmvhZ_r447uArW-_6yK0r7V9BkzX7i+E7MvruA9Q@mail.gmail.com>
On Mon, Oct 9, 2023 at 9:46 AM Naomi Ibe <naomi.ibeh69@gmail.com> wrote:
>
> Okay I understand it better now ,can I do anything about it? Or should
> I leave it as is?.

I think you should send a version 2 of the patch (so without a cover letter) taking into account the comments I made about it. You might want to wait a bit before sending version 2 though, so that others might have time to read your patch and give you more feedback about it.

> It's my first time using the "git patch
I guess you mean `git format-patch`.
> and "git send-email"
> commands, so it was a real struggle understanding the proper way to
> get things setup.

Yeah, it's not easy to set things up, but once that's done it should be much easier. To make things even easier, you could perhaps save somewhere the commands that you have previously used. And to improve or make changes to those commands, you could take a look at the documentation for `git format-patch` and `git send-email` which have a number of interesting options, and take note of those interesting options.

Previous: Naomi IbeNext: Naomi Ibe
Message 4 of 5 in “*** EDITED add.c ***”
  1. 0/1 *** EDITED add.c ***Naomi Ibe, Oct 9, 2023
  2. Christian CouderOct 9, 2023
  3. Naomi IbeOct 9, 2023
  4. Christian CouderOct 9, 2023
  5. Naomi IbeOct 9, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.