Naomi Ibe*** BLURB HERE ***
Naomi (1):
[OUTREACHY] Fixed add.c file to conform to guidelines when using die()
listed in issue #635builtin/add.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
-- 2.36.1.windows.1
Naomi Ibe
Christian CouderRe: [PATCH 0/1] *** EDITED add.c ***
On Mon, Oct 9, 2023 at 3:19 AM Naomi Ibe <naomi.ibeh69@gmail.com> wrote:
> > *** BLURB HERE ***
A patch with number 0/X (where X is any number) is called a "cover letter" and is supposed to explain the purpose of the patch series it is part of. Usually a cover letter is not useful for a single patch long patch series (when X is 1), as the commit message of the patch should be enough.
Also things like "*** BLURB HERE ***" (including the stars) are supposed to be replaced by a subject or some comments to explain things.
Naomi IbeRe: [PATCH 0/1] *** EDITED add.c ***
Okay I understand it better now ,can I do anything about it? Or should I leave it as is?. It's my first time using the "git patch" and "git send-email" commands, so it was a real struggle understanding the proper way to get things setup.
On Mon, Oct 9, 2023 at 8:39 AM Christian Couder <christian.couder@gmail.com> wrote:
Show 14 quoted lines
> > On Mon, Oct 9, 2023 at 3:19 AM Naomi Ibe <naomi.ibeh69@gmail.com> wrote: > > > > *** BLURB HERE *** > > A patch with number 0/X (where X is any number) is called a "cover > letter" and is supposed to explain the purpose of the patch series it > is part of. Usually a cover letter is not useful for a single patch > long patch series (when X is 1), as the commit message of the patch > should be enough. > > Also things like "*** BLURB HERE ***" (including the stars) are > supposed to be replaced by a subject or some comments to explain > things.
Christian CouderRe: [PATCH 0/1] *** EDITED add.c ***
On Mon, Oct 9, 2023 at 9:46 AM Naomi Ibe <naomi.ibeh69@gmail.com> wrote:
> > Okay I understand it better now ,can I do anything about it? Or should > I leave it as is?.
I think you should send a version 2 of the patch (so without a cover letter) taking into account the comments I made about it. You might want to wait a bit before sending version 2 though, so that others might have time to read your patch and give you more feedback about it.
> It's my first time using the "git patch
I guess you mean `git format-patch`.
> and "git send-email" > commands, so it was a real struggle understanding the proper way to > get things setup.
Yeah, it's not easy to set things up, but once that's done it should be much easier. To make things even easier, you could perhaps save somewhere the commands that you have previously used. And to improve or make changes to those commands, you could take a look at the documentation for `git format-patch` and `git send-email` which have a number of interesting options, and take note of those interesting options.
Naomi IbeRe: [PATCH 0/1] *** EDITED add.c ***
Okay then, I'd wait for additional feedback and send in a Version 2 later. Thank you
On Mon, Oct 9, 2023 at 9:03 AM Christian Couder <christian.couder@gmail.com> wrote:
Show 27 quoted lines
> > On Mon, Oct 9, 2023 at 9:46 AM Naomi Ibe <naomi.ibeh69@gmail.com> wrote: > > > > Okay I understand it better now ,can I do anything about it? Or should > > I leave it as is?. > > I think you should send a version 2 of the patch (so without a cover > letter) taking into account the comments I made about it. You might > want to wait a bit before sending version 2 though, so that others > might have time to read your patch and give you more feedback about > it. > > > It's my first time using the "git patch > > I guess you mean `git format-patch`. > > > and "git send-email" > > commands, so it was a real struggle understanding the proper way to > > get things setup. > > Yeah, it's not easy to set things up, but once that's done it should > be much easier. To make things even easier, you could perhaps save > somewhere the commands that you have previously used. And to improve > or make changes to those commands, you could take a look at the > documentation for `git format-patch` and `git send-email` which have a > number of interesting options, and take note of those interesting > options.