Re: [PATCH 2/2] fast-import: add '--signed-commits=<mode>' option

From: Christian Couder <christian.couder@gmail.com>
Date: Sep 12, 2025, 13:41 UTC
Message-ID: <CAP8UFD39y8Xde6CD=dDyYy3MY1NOaZGVuwk4zPcreA5KbKR1dA@mail.gmail.com>
In-Reply-To: <xmqqms72rwx4.fsf@gitster.g>

On Wed, Sep 10, 2025 at 8:21 PM Junio C Hamano <gitster@pobox.com> wrote:

>
> Christian Couder <christian.couder@gmail.com> writes:

Show 20 quoted lines

> > +--signed-commits=(verbatim|warn-verbatim|warn-strip|strip|abort)::
> > +     Specify how to handle signed commits.  Behaves in the same way
> > +     as the same option in linkgit:git-fast-export[1], except that
> > +     default is 'verbatim' (instead of 'abort').
>
> I forgot one thing.  Earlier in 1/2 we saw
>
>     The definition of 'enum sign_mode' as well as its parsing code are in
>     "builtin/fast-export.c". This was fine because `git fast-export` was the
>     only command with '--signed-tags=<mode>' or '--signed-commits=<mode>'
>     options.
>
>     In a following commit, we are going to add such options to `git
>     fast-import`, which will be simpler, easier and cleaner if we can reuse
>     the 'enum sign_mode' defintion and parsing code.
>
> and I was implicitly expecting that both commits and tags would be
> supported on the import side, but this only deals with the commits?
>
> Is patch [3/2] missing from the archive?

Yeah, the commit message was too optimistic about the features that were going to be added by the next commit.

In V2, I have changed that paragraph in the commit message to:

   "In a following commit, we are going to add a similar option to `git
   fast-import`, which will be simpler, easier and cleaner if we can reuse
   the 'enum sign_mode' defintion and parsing code."

And in the cover letter I added the following:

"In the future I also plan to add a similar `--signed-tags=<mode>` so that the import of tags can also be controlled. But I prefer to validate the general design of a single new option first."

I hope it's Ok.

Thanks.