Re: [PATCH 2/2] fast-import: add '--signed-commits=<mode>' option

From: Christian Couder <christian.couder@gmail.com>
Date: Sep 17, 2025, 18:27 UTC
Message-ID: <CAP8UFD1yW4SW1Nj=UfBq89UHVGJi6zPuhUEd5XbPBfSBh+x4xg@mail.gmail.com>
In-Reply-To: <xmqqecs7iu0a.fsf@gitster.g>

On Mon, Sep 15, 2025 at 6:02 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

>
> Christian Couder <christian.couder@gmail.com> writes:
>
> > So it seems to me that I should change the code back so that its
> > behavior is the same as in v1, while trying to avoid what you called
> > code ergonomics regression when you reviewed v1. Ok, let's see if I
> > find a way to do that.
>
> Sorry, the above reads like (but it is a bit fuzzy and oblique to me
> to be certain) I suggested a wrong approach on v1 which we are
> seeing in the version under review and I am suggesting to reverse
> course?

I just hoped to get hints in case you had an idea I didn't understand about how the code should look like.

> It is a bit too far apart between versions so I am not sure
> if that is what is happening, but if so, sorry for making you polish
> itrepeatedly.

No worries. I hope the V3 I just sent is better than both the v1 and v2, or at least that it moves us closer to something better than both of them.

Thanks.