Re: Draft of Git Rev News edition 38

From: Christian Couder <christian.couder@gmail.com>
Date: Apr 16, 2018, 22:26 UTC
Message-ID: <CAP8UFD34Y0KRY7vqXU_jWGUc3tdDHB1h67ARZxi_vk1EyUV+zQ@mail.gmail.com>
In-Reply-To: <72f42205-c9c6-03aa-e8df-12e7062e8e62@gmail.com>

Hi,

On Mon, Apr 16, 2018 at 5:07 PM, Kaartic Sivaraam <kaartic.sivaraam@gmail.com> wrote:

>
> That said, I read the draft and found it good except for two minor issues,

Thanks for your comments!

Show 10 quoted lines

> 1. I see the following sentence in the "Rebasing merges: a jorney to the
> ultimate solution (Road Clear) (written by Jacob Keller)" article
>
>         "A few examples were tried, but it was proven that the original
>         concept did not work, as dropped commits could end up being
>         replaid into the merge commits, turning them into "evil"
>         merges."
>
> I'm not sure if 'replaid' is proper English assuming the past tense of
> replay was intended there (which I think is 'replayed').

I agree and changed it to "replayed".

Show 7 quoted lines

> 2. I see a minor Markdown syntax issue in the "branch -l: print useful
> info whilst rebasing a non-local branch" article.
>
>         ... reworked his original patch to improve `git branch
>         --list̀
>
> Specifically, in the '--list̀' part. I guess it should be "--list`".

Yeah, it's fixed too.

Thanks, Christian.