Re: Draft of Git Rev News edition 38

From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date: Apr 16, 2018, 15:07 UTC
Message-ID: <72f42205-c9c6-03aa-e8df-12e7062e8e62@gmail.com>
In-Reply-To: <87sh7v6vn4.fsf@javad.com>

Hi,

On Monday 16 April 2018 08:33 PM, Sergey Organov wrote:

> Christian Couder <christian.couder@gmail.com> writes:
>> Here "the above article" means the Jake's "branch -l: print useful
>> info whilst rebasing a non-local branch" article above the current
>> article.

Just a little correction. I suppose Chris actually meant the "rebase -i: offer to recreate merge commits" article written by Jake and not the "branch -l: print useful info whilst rebasing a non-local branch" article.

That said, I read the draft and found it good except for two minor issues,

1. I see the following sentence in the "Rebasing merges: a jorney to the
ultimate solution (Road Clear) (written by Jacob Keller)" article

	"A few examples were tried, but it was proven that the original
	concept did not work, as dropped commits could end up being
	replaid into the merge commits, turning them into "evil"
	merges."

I'm not sure if 'replaid' is proper English assuming the past tense of replay was intended there (which I think is 'replayed').

2. I see a minor Markdown syntax issue in the "branch -l: print useful
info whilst rebasing a non-local branch" article.

	... reworked his original patch to improve `git branch
	--list̀

Specifically, in the '--list̀' part. I guess it should be "--list`".

-- 
Kaartic

QUOTE:

“The most valuable person on any team is the person who makes everyone
else on the team more valuable, not the person who knows the most.”

      - Joel Spolsky