Re: [GSOC][RFC PATCH 1/1] t: t7301-clean-interactive: Use test_path_is_(missing|file)
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Feb 26, 2024, 10:13 UTC
- Message-ID
- <CAP8UFD3153ZMEeEU3yPdBQZMzJxqgtX5YdxKwWfnVVwZKqHn-Q@mail.gmail.com>
- In-Reply-To
- <20240219172214.7644-2-vincenzo.mezzela@gmail.com>
About the subject, instead of "t: t7301-clean-interactive: Use ...", something like "t7301-clean-interactive: use ..." or "t7301: use ..." would be better. First because there is no need for both "t:" and "t7301-clean-interactive:" for the "area" part of the subject. Only one "area" part is enough. Second because the first word after the "area" part should not be capitalized. See: https://git-scm.com/docs/SubmittingPatches/#summary-section
On Mon, Feb 19, 2024 at 6:22 PM Vincenzo Mezzela <vincenzo.mezzela@gmail.com> wrote:
> > Replace test -(f|e) with the appropriate helper functions provided by > test-lib-functions.sh
I think your commit message should explain why it's better to use test_path_is_(missing|file) instead of test -(f|e).
Also replacing `test ! -f` with `test_path_is_missing` might be wrong if it's Ok to have a directory instead of a file (in which case the latter would fail while the former would work). So a few words about why it's Ok to do it here would be nice.
Thanks!