Re: [PATCH v13 00/14] libify apply and use lib in am, part 3

From: Christian Couder <christian.couder@gmail.com>
Date: Sep 4, 2016, 20:17 UTC
Message-ID: <CAP8UFD3+=g+UqwkW7wUG3q3gmShg+6hw6SaGQ0-AfVEVJ6_w7w@mail.gmail.com>
In-Reply-To: <xmqqzinrwly4.fsf@gitster.mtv.corp.google.com>

On Thu, Sep 1, 2016 at 7:48 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Christian Couder <christian.couder@gmail.com> writes:
>
>> Following Stefan's review, it looks like I will need to resend at
>> least 02/14, 10/14 and 14/14.
>> What do you prefer me to resend:
>> 1) all the last 40 or so patches
>> 2) the last 14 patches
>> 3) only the few patches that changed
>
> If this reroll is to be the candidate to be the final one, I'd
> prefer to see 1 to give an easy access to more sets of eyes, but if
> you just send them without giving these patches one more read-over
> before sending them out, it is not as valuable as it would be.

Ok, I will send the 41 patches very soon after having given them one more read over and implementing the few changes suggested by Stefan and Ramsay and one improvement I spotted.

> I think 2 is of the least value.
>
> If you do 3., pointing people at where the remainder of the series
> can be found is necessary.

There is always a pointer to the full patch series on GitHub anyway in the cover letter, but I will send everything anyway.