Re: [PATCH v13 14/14] builtin/am: use apply API in run_apply()

From: Christian Couder <christian.couder@gmail.com>
Date: Sep 1, 2016, 07:41 UTC
Message-ID: <CAP8UFD2C_y91+nYBoavq_cPWrUcoJ97jDvs64sBabL6kbpjehw@mail.gmail.com>
In-Reply-To: <CAGZ79kZcK-QxMUa7A0FJbzq=ZQ=prWzJu4K69jaW8E-rwme=oQ@mail.gmail.com>

On Thu, Sep 1, 2016 at 12:33 AM, Stefan Beller <sbeller@google.com> wrote:

Show 9 quoted lines

> On Sat, Aug 27, 2016 at 11:45 AM, Christian Couder
> <christian.couder@gmail.com> wrote:
>> +
>> +       if (opts_left != 0)
>> +               die("unknown option passed thru to git apply");
>
> Through and thru are different spellings of the same word.
> Thru is the less preferred form, however, and it might be
> considered out of place outside the most informal contexts.

Ok I will change to "through"...

> [Source: The Internet]
>
> "git grep thru" confirms we only use it in comments or function
> names, both are not exposed to our dear users.

...but I find it strange to use different kind of language for our users, who by the way are likely to be developers, than for our own developers.

> The rest looks good.

Thanks for your review, Christian.