Re: [PATCH] helper/test-ref-store: fix "new-sha1" vs "old-sha1" typo

From: Christian Couder <christian.couder@gmail.com>
Date: Jan 16, 2019, 11:13 UTC
Message-ID: <CAP8UFD2vLhn1_hUefKfsE8+3SDZk6qzf8eS-DUoZLhf41QiyAg@mail.gmail.com>
In-Reply-To: <CACsJy8B7ogYEzwDAT7v1z4T-YsTa-e3VPbCfNBmc4v5R=06meA@mail.gmail.com>

On Mon, Jan 7, 2019 at 1:53 PM Duy Nguyen <pclouds@gmail.com> wrote:

Show 11 quoted lines

>
> On Sun, Jan 6, 2019 at 10:46 PM Christian Couder
> <christian.couder@gmail.com> wrote:
> >
> > It looks like it is a copy-paste error  made in 80f2a6097c
> > (t/helper: add test-ref-store to test ref-store functions,
> > 2017-03-26) to pass "old-sha1" instead of "new-sha1" to
> > notnull() when we get the new sha1 argument from
> > const char **argv.
>
> Ack. Definitely copy-paste error.

Thanks for confirming.

Junio, it looks like the patch has fallen through the cracks.

Or maybe I should rework the commit message?