git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] helper/test-ref-store: fix "new-sha1" vs "old-sha1" typo

From
Christian Couder <christian.couder@gmail.com>
Date
Jan 6, 2019, 15:46 UTC
Message-ID
<20190106154637.10815-1-chriscool@tuxfamily.org>

It looks like it is a copy-paste error made in 80f2a6097c (t/helper: add test-ref-store to test ref-store functions, 2017-03-26) to pass "old-sha1" instead of "new-sha1" to notnull() when we get the new sha1 argument from const char **argv.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 t/helper/test-ref-store.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/helper/test-ref-store.c b/t/helper/test-ref-store.c
index e9e0541276..799fc00aa1 100644
--- a/t/helper/test-ref-store.c
+++ b/t/helper/test-ref-store.c
@@ -233,7 +233,7 @@ static int cmd_update_ref(struct ref_store *refs, const char **argv)
 {
 	const char *msg = notnull(*argv++, "msg");
 	const char *refname = notnull(*argv++, "refname");
-	const char *new_sha1_buf = notnull(*argv++, "old-sha1");
+	const char *new_sha1_buf = notnull(*argv++, "new-sha1");
 	const char *old_sha1_buf = notnull(*argv++, "old-sha1");
 	unsigned int flags = arg_flags(*argv++, "flags");
 	struct object_id old_oid;
-- 
2.20.1.26.gc246996f60
Next: Duy Nguyen
Message 1 of 4 in “helper/test-ref-store: fix "new-sha1" vs "old-sha1" typo”
  1. helper/test-ref-store: fix "new-sha1" vs "old-sha1" typoChristian Couder, Jan 6, 2019
  2. Duy NguyenJan 7, 2019
  3. Christian CouderJan 16, 2019
  4. Junio C HamanoJan 17, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.