git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 16/21] read-cache: unlink old sharedindex files

From
Christian Couder <christian.couder@gmail.com>
Date
Dec 26, 2016, 09:54 UTC
Message-ID
<CAP8UFD2hE5nLXKpSEPaS_1XYqQw+Wn=nMT4paV+FtGFrHzHsFw@mail.gmail.com>
In-Reply-To
<20161219115812.GD24125@ash>
On Mon, Dec 19, 2016 at 12:58 PM, Duy Nguyen <pclouds@gmail.com> wrote:
Show 23 quoted lines
> On Sat, Dec 17, 2016 at 03:55:42PM +0100, Christian Couder wrote:
>> +static int clean_shared_index_files(const char *current_hex)
>> +{
>> +     struct dirent *de;
>> +     DIR *dir = opendir(get_git_dir());
>> +
>> +     if (!dir)
>> +             return error_errno(_("unable to open git dir: %s"), get_git_dir());
>> +
>> +     while ((de = readdir(dir)) != NULL) {
>> +             const char *sha1_hex;
>> +             if (!skip_prefix(de->d_name, "sharedindex.", &sha1_hex))
>> +                     continue;
>> +             if (!strcmp(sha1_hex, current_hex))
>
> fspathcmp since we're dealing fs paths?
>
> In theory we should be ok using strcmp, even on Windows because case
> is preserved, I think. It's only a problem when we write path 'abc'
> down and read 'ABC' back.
>
> Oh well.. your call because if you go with fspathcmp, skip_prefix can't
> be used either. A lot more changes for a very rare case.
I'd rather keep using skip_prefix() and strcmp().

I could find no place in the code where fspathcmp() is used to compare dir entries, but a few where other *cmp() functions are used:

$ git grep '>d_name' | grep cmp builtin/repack.c: if (strncmp(e->d_name, buf.buf + dirlen, prefixlen)) dir.c: if (is_dot_or_dotdot(de->d_name) || !strcmp(de->d_name, ".git")) sha1_name.c: if (memcmp(de->d_name, ds->hex_pfx + 2, ds->len - 2))

and also a few where skip_prefix() is used:

$ git grep -n '>d_name' | grep prefix builtin/repack.c:60: if (strncmp(e->d_name, buf.buf + dirlen, prefixlen)) help.c:147: if (!skip_prefix(de->d_name, prefix, &ent))

so I think it is ok to use skip_prefix() and strcmp().
Show 5 quoted lines
>> +                     continue;
>> +             if (can_delete_shared_index(sha1_hex) > 0 &&
>
> Probably shorter to pass full d->name here so you don't have to do
> another git_path() in can_delete_
Yeah, you are right, I will do that.
Previous: Duy NguyenNext: Christian Couder
Message 13 of 34 in “Add configuration options for split-index”
  1. 00/21 Add configuration options for split-indexChristian Couder, Dec 17, 2016
  2. 01/21 config: mark an error message up for translationChristian Couder, Dec 17, 2016
  3. 02/21 config: add git_config_get_split_index()Christian Couder, Dec 17, 2016
  4. Duy NguyenDec 19, 2016
  5. Christian CouderDec 26, 2016
  6. 06/21 t1700: add tests for core.splitIndexChristian Couder, Dec 17, 2016
  7. 09/21 config: add git_config_get_max_percent_split_change()Christian Couder, Dec 17, 2016
  8. 08/21 Documentation/git-update-index: talk about core.splitIndex config varChristian Couder, Dec 17, 2016
  9. 12/21 Documentation/config: add splitIndex.maxPercentChangeChristian Couder, Dec 17, 2016
  10. 14/21 read-cache: touch shared index files when usedChristian Couder, Dec 17, 2016
  11. 16/21 read-cache: unlink old sharedindex filesChristian Couder, Dec 17, 2016
  12. Duy NguyenDec 19, 2016
  13. Christian CouderDec 26, 2016
  14. 17/21 t1700: test shared index file expirationChristian Couder, Dec 17, 2016
  15. 19/21 read-cache: use freshen_shared_index() in read_index_from()Christian Couder, Dec 17, 2016
  16. 21/21 Documentation/git-update-index: explain splitIndex.*Christian Couder, Dec 17, 2016
  17. 20/21 Documentation/config: add splitIndex.sharedIndexExpireChristian Couder, Dec 17, 2016
  18. 11/21 t1700: add tests for splitIndex.maxPercentChangeChristian Couder, Dec 17, 2016
  19. 05/21 update-index: warn in case of split-index incoherencyChristian Couder, Dec 17, 2016
  20. 13/21 sha1_file: make check_and_freshen_file() non staticChristian Couder, Dec 17, 2016
  21. 18/21 read-cache: refactor read_index_from()Christian Couder, Dec 17, 2016
  22. 15/21 config: add git_config_get_expiry() from gc.cChristian Couder, Dec 17, 2016
  23. 10/21 read-cache: regenerate shared index if necessaryChristian Couder, Dec 17, 2016
  24. Duy NguyenDec 19, 2016
  25. Christian CouderDec 26, 2016
  26. 04/21 read-cache: add and then use tweak_split_index()Christian Couder, Dec 17, 2016
  27. Duy NguyenDec 19, 2016
  28. Christian CouderDec 26, 2016
  29. 03/21 split-index: add {add,remove}_split_index() functionsChristian Couder, Dec 17, 2016
  30. 07/21 Documentation/config: add information for core.splitIndexChristian Couder, Dec 17, 2016
  31. Christian CouderDec 17, 2016
  32. Duy NguyenDec 19, 2016
  33. Junio C HamanoDec 19, 2016
  34. Christian CouderDec 26, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.