git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 04/21] read-cache: add and then use tweak_split_index()

From
Christian Couder <christian.couder@gmail.com>
Date
Dec 26, 2016, 08:20 UTC
Message-ID
<CAP8UFD0KwbQo4QgC9cevcdHWBwedy-qCUXcDqaeissv4U=5RyQ@mail.gmail.com>
In-Reply-To
<20161219111843.GB24125@ash>
On Mon, Dec 19, 2016 at 12:18 PM, Duy Nguyen <pclouds@gmail.com> wrote:
Show 18 quoted lines
> On Sat, Dec 17, 2016 at 03:55:30PM +0100, Christian Couder wrote:
>> +static void tweak_split_index(struct index_state *istate)
>> +{
>> +     switch (git_config_get_split_index()) {
>> +     case -1: /* unset: do nothing */
>> +             break;
>> +     case 0: /* false */
>> +             remove_split_index(istate);
>> +             break;
>> +     case 1: /* true */
>> +             add_split_index(istate);
>> +             break;
>> +     default: /* unknown value: do nothing */
>
> Probably should die("BUG:") here since it looks to me like
> git_config_maybe_bool() (inside git_config_get_split_index) in this
> case has been updated to return more values than we can handle. And we
> need to know about that so we can handle it properly.

If we later add another value to the possible ones, like for example "auto", we might not want old versions of Git to fail with a "BUG:..." message when they read config files tweaked for newer Git versions, so I don't think we should die() here.

A warning would be ok, but given that in tweak_untracked_cache() we decided to do nothing, I am thinking that it would be more consistent to just do nothing here too.

Previous: Duy NguyenNext: Christian Couder
Message 28 of 34 in “Add configuration options for split-index”
  1. 00/21 Add configuration options for split-indexChristian Couder, Dec 17, 2016
  2. 01/21 config: mark an error message up for translationChristian Couder, Dec 17, 2016
  3. 02/21 config: add git_config_get_split_index()Christian Couder, Dec 17, 2016
  4. Duy NguyenDec 19, 2016
  5. Christian CouderDec 26, 2016
  6. 06/21 t1700: add tests for core.splitIndexChristian Couder, Dec 17, 2016
  7. 09/21 config: add git_config_get_max_percent_split_change()Christian Couder, Dec 17, 2016
  8. 08/21 Documentation/git-update-index: talk about core.splitIndex config varChristian Couder, Dec 17, 2016
  9. 12/21 Documentation/config: add splitIndex.maxPercentChangeChristian Couder, Dec 17, 2016
  10. 14/21 read-cache: touch shared index files when usedChristian Couder, Dec 17, 2016
  11. 16/21 read-cache: unlink old sharedindex filesChristian Couder, Dec 17, 2016
  12. Duy NguyenDec 19, 2016
  13. Christian CouderDec 26, 2016
  14. 17/21 t1700: test shared index file expirationChristian Couder, Dec 17, 2016
  15. 19/21 read-cache: use freshen_shared_index() in read_index_from()Christian Couder, Dec 17, 2016
  16. 21/21 Documentation/git-update-index: explain splitIndex.*Christian Couder, Dec 17, 2016
  17. 20/21 Documentation/config: add splitIndex.sharedIndexExpireChristian Couder, Dec 17, 2016
  18. 11/21 t1700: add tests for splitIndex.maxPercentChangeChristian Couder, Dec 17, 2016
  19. 05/21 update-index: warn in case of split-index incoherencyChristian Couder, Dec 17, 2016
  20. 13/21 sha1_file: make check_and_freshen_file() non staticChristian Couder, Dec 17, 2016
  21. 18/21 read-cache: refactor read_index_from()Christian Couder, Dec 17, 2016
  22. 15/21 config: add git_config_get_expiry() from gc.cChristian Couder, Dec 17, 2016
  23. 10/21 read-cache: regenerate shared index if necessaryChristian Couder, Dec 17, 2016
  24. Duy NguyenDec 19, 2016
  25. Christian CouderDec 26, 2016
  26. 04/21 read-cache: add and then use tweak_split_index()Christian Couder, Dec 17, 2016
  27. Duy NguyenDec 19, 2016
  28. Christian CouderDec 26, 2016
  29. 03/21 split-index: add {add,remove}_split_index() functionsChristian Couder, Dec 17, 2016
  30. 07/21 Documentation/config: add information for core.splitIndexChristian Couder, Dec 17, 2016
  31. Christian CouderDec 17, 2016
  32. Duy NguyenDec 19, 2016
  33. Junio C HamanoDec 19, 2016
  34. Christian CouderDec 26, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.