Re: [PATCH] pack: make packed_git_mru global a value instead of a pointer

From: Christian Couder <christian.couder@gmail.com>
Date: Sep 17, 2017, 20:44 UTC
Message-ID: <CAP8UFD2d7y9COGj=bRLk_d+F_M=c7nv802AjBf=R9NnJQB7ohA@mail.gmail.com>
In-Reply-To: <CAP8UFD2f3jXkRHb_S_dK7TDfhBwXQ+O63cBn0J7iQQA-5ysVMQ@mail.gmail.com>

On Sun, Sep 17, 2017 at 10:42 PM, Christian Couder <christian.couder@gmail.com> wrote:

Show 13 quoted lines

> On Sun, Sep 17, 2017 at 10:17 PM, phionah bugosi <bugosip@gmail.com> wrote:
>> Signed-off-by: phionah bugosi <bugosip@gmail.com>
>> ---
>>  builtin/pack-objects.c |  5 +++--
>>  cache.h                |  7 -------
>>  list.h                 |  6 ++++++
>>  packfile.c             | 12 ++++++------
>>  4 files changed, 15 insertions(+), 15 deletions(-)
>>
>> This patch makes packed_git_mru global a value instead of a pointer and
>> makes use of list.h
>
> Please explain _why_ you are doing that (why is the resulting code better).

Also the explanations should be in the commit message, that is above your "Signed-off-by: ..." line.