git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Outreachy PATCH v3 1/2] remote: add repo_for_each_remote()

From
Christian Couder <christian.couder@gmail.com>
Date
Nov 3, 2026, 12:41 UTC
Message-ID
<CAP8UFD2_msUwNf1Opvt95jFWBoPi5H8jNCpQcH0ohYh26F4fLg@mail.gmail.com>
In-Reply-To
<20261023211533.73433-2-okhuomonajayi54@gmail.com>

On Fri, Oct 23, 2026 at 11:15 PM Okhuomon Ajayi <okhuomonajayi54@gmail.com> wrote:

Show 13 quoted lines
> -int for_each_remote(each_remote_fn fn, void *priv)
> +int repo_for_each_remote(struct repository *repo,
> +                        each_remote_fn fn, void *priv)
>  {
>         int i, result = 0;
> -       read_config(the_repository, 0);
> -       for (i = 0; i < the_repository->remote_state->remotes_nr && !result;
> +       read_config(repo, 0);
> +       for (i = 0; i < repo->remote_state->remotes_nr && !result;
>              i++) {
>                 struct remote *remote =
> -                       the_repository->remote_state->remotes[i];
> +                       repo->remote_state->remotes[i];

It looks like moving from `the_repository` to `repo` could be a good opportunity to unwrap some lines. For example something like:

        int result = 0;
        read_config(repo, 0);
        for (int i = 0; i < repo->remote_state->remotes_nr && !result; i++) {
                struct remote *remote = repo->remote_state->remotes[i];
keeps lines under our 80 characters limit and is a bit nicer to read.
Thanks.
>                 if (!remote)
>                         continue;
>                 result = fn(remote, priv);
Previous: Okhuomon AjayiNext: Okhuomon Ajayi
Message 10 of 14 in “checkout: use repository parameter in unique_tracking_name”
  1. checkout: use repository parameter in unique_tracking_nameOkhuomon Ajayi, Oct 17, 2026
  2. Usman AkinyemiOct 22, 2026
  3. Okhuomon AjayiOct 22, 2026
  4. checkout: pass the repository to unique_tracking_name()Okhuomon Ajayi, Oct 22, 2026
  5. Junio C HamanoOct 22, 2026
  6. Junio C HamanoOct 22, 2026
  7. Okhuomon AjayiOct 22, 2026
  8. 0/2 checkout: make unique_tracking_name() use the given repositoryOkhuomon Ajayi, Oct 23, 2026
  9. 1/2 remote: add repo_for_each_remote()Okhuomon Ajayi, Oct 23, 2026
  10. Christian CouderNov 3, 2026
  11. 2/2 checkout: pass the repository to unique_tracking_name()Okhuomon Ajayi, Oct 23, 2026
  12. 0/2 checkout: make unique_tracking_name() use the given repositoryOkhuomon Ajayi, Nov 4, 2026
  13. 1/2 remote: add repo_for_each_remote()Okhuomon Ajayi, Nov 4, 2026
  14. 2/2 checkout: pass the repository to unique_tracking_name()Okhuomon Ajayi, Nov 4, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.