Re: [Outreachy PATCH v3 1/2] remote: add repo_for_each_remote()
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Nov 3, 2026, 12:41 UTC
- Message-ID
- <CAP8UFD2_msUwNf1Opvt95jFWBoPi5H8jNCpQcH0ohYh26F4fLg@mail.gmail.com>
- In-Reply-To
- <20261023211533.73433-2-okhuomonajayi54@gmail.com>
On Fri, Oct 23, 2026 at 11:15 PM Okhuomon Ajayi <okhuomonajayi54@gmail.com> wrote:
Show 13 quoted lines
> -int for_each_remote(each_remote_fn fn, void *priv)
> +int repo_for_each_remote(struct repository *repo,
> + each_remote_fn fn, void *priv)
> {
> int i, result = 0;
> - read_config(the_repository, 0);
> - for (i = 0; i < the_repository->remote_state->remotes_nr && !result;
> + read_config(repo, 0);
> + for (i = 0; i < repo->remote_state->remotes_nr && !result;
> i++) {
> struct remote *remote =
> - the_repository->remote_state->remotes[i];
> + repo->remote_state->remotes[i];It looks like moving from `the_repository` to `repo` could be a good opportunity to unwrap some lines. For example something like:
int result = 0;
read_config(repo, 0);
for (int i = 0; i < repo->remote_state->remotes_nr && !result; i++) {
struct remote *remote = repo->remote_state->remotes[i];keeps lines under our 80 characters limit and is a bit nicer to read.
Thanks.
> if (!remote) > continue; > result = fn(remote, priv);