Re: [Outreachy PATCH v2] checkout: pass the repository to unique_tracking_name()
- From
- Okhuomon Ajayi <okhuomonajayi54@gmail.com>
- Date
- Oct 22, 2026, 21:23 UTC
- Message-ID
- <CAFpMFfAhONvaXUVHhkXr9KV-G5hKT2kLi4pa4qZMpVZQUWgBxg@mail.gmail.com>
- In-Reply-To
- <xmqqo6clfu19.fsf@gitster.g>
On Thu, Oct 22, 2026 at 7:51 PM Junio C Hamano <gitster@pobox.com> wrote:
> The mention of for_each_remote() feels weirdly abrupt. Many other > things still rely on the the_repository global variable, but > there must be a reason why for_each_remote() is singled out in the > context of this patch. What is it?
Thanks for the review.
You are right. I mentioned for_each_remote() because unique_tracking_name() calls it to go through the remotes, and it still reads them from the_repository. So the new repository parameter is not used everywhere yet, and a caller passing a different repository would not get the right result.
I will look into this more closely before sending anything else.
Thanks, Okhuomon