git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Outreachy PATCH v2] checkout: pass the repository to unique_tracking_name()

From
OAOkhuomon Ajayi <okhuomonajayi54@gmail.com>
Date
Oct 22, 2026, 21:23 UTC
Message-ID
<CAFpMFfAhONvaXUVHhkXr9KV-G5hKT2kLi4pa4qZMpVZQUWgBxg@mail.gmail.com>
In-Reply-To
<xmqqo6clfu19.fsf@gitster.g>
On Thu, Oct 22, 2026 at 7:51 PM Junio C Hamano <gitster@pobox.com> wrote:
> The mention of for_each_remote() feels weirdly abrupt.  Many other
> things still rely on the the_repository global variable, but
> there must be a reason why for_each_remote() is singled out in the
> context of this patch.  What is it?
Thanks for the review.

You are right. I mentioned for_each_remote() because unique_tracking_name() calls it to go through the remotes, and it still reads them from the_repository. So the new repository parameter is not used everywhere yet, and a caller passing a different repository would not get the right result.

I will look into this more closely before sending anything else.

Thanks, Okhuomon

Previous: Junio C HamanoNext: Okhuomon Ajayi
Message 7 of 14 in “checkout: use repository parameter in unique_tracking_name”
  1. checkout: use repository parameter in unique_tracking_nameOkhuomon Ajayi, Oct 17, 2026
  2. Usman AkinyemiOct 22, 2026
  3. Okhuomon AjayiOct 22, 2026
  4. checkout: pass the repository to unique_tracking_name()Okhuomon Ajayi, Oct 22, 2026
  5. Junio C HamanoOct 22, 2026
  6. Junio C HamanoOct 22, 2026
  7. Okhuomon AjayiOct 22, 2026
  8. 0/2 checkout: make unique_tracking_name() use the given repositoryOkhuomon Ajayi, Oct 23, 2026
  9. 1/2 remote: add repo_for_each_remote()Okhuomon Ajayi, Oct 23, 2026
  10. Christian CouderNov 3, 2026
  11. 2/2 checkout: pass the repository to unique_tracking_name()Okhuomon Ajayi, Oct 23, 2026
  12. 0/2 checkout: make unique_tracking_name() use the given repositoryOkhuomon Ajayi, Nov 4, 2026
  13. 1/2 remote: add repo_for_each_remote()Okhuomon Ajayi, Nov 4, 2026
  14. 2/2 checkout: pass the repository to unique_tracking_name()Okhuomon Ajayi, Nov 4, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.