Re: [PATCH] drop support for "experimental" loose objects
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Nov 21, 2013, 20:19 UTC
- Message-ID
- <CAP8UFD2S1HUDYLbmEGFqLcBFExuB0h7=gqwsQ0qjpMSc+YaXog@mail.gmail.com>
- In-Reply-To
- <20131121160426.GA21843@kitenet.net>
On Thu, Nov 21, 2013 at 5:04 PM, Joey Hess <joey@kitenet.net> wrote:
Show 5 quoted lines
> > BTW, I've also seen git cat-file --batch report wrong sizes for objects, > sometimes without crashing. This is particularly problimatic because if > the object size is wrong, it's very hard to detect the actual end of the > object output in the batch mode stream.
Yeah, I think it might report wrong size in case of replaced objects for example. I looked at that following Junio's comment about the sha1_object_info() API, which, unlike read_sha1_file() API, does not interact with the "replace" mechanism:
http://thread.gmane.org/gmane.comp.version-control.git/234023/
I started to work on a patch about this but didn't take the time to finish and post it.
Thanks, Christian.