git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] remote-odb: un-inline function remote_odb_reinit

From
Christian Couder <christian.couder@gmail.com>
Date
Jul 25, 2018, 07:29 UTC
Message-ID
<CAP8UFD2PxA4s=Gb-6paUAdWpmqMWpis3mn0Zz9nzqQhHt1EEBg@mail.gmail.com>
In-Reply-To
<cf9889ba-89c5-dc97-d888-aa42aa9dee68@drbeat.li>
Hi,
On Wed, Jul 25, 2018 at 12:03 AM, Beat Bolli <dev+git@drbeat.li> wrote:
>
> On 24.07.18 23:59, Jonathan Nieder wrote:
>>
>> Beat Bolli wrote:
Show 11 quoted lines
>>> -inline void remote_odb_reinit(void)
>>> +void remote_odb_reinit(void)
>>
>> This looks like an oversight in
>> https://public-inbox.org/git/20180713174959.16748-6-chriscool@tuxfamily.org/:
>> there isn't any reason for this function to be inline.
>>
>> Christian, can you squash it in on your next reroll?
>
> That would probably make sense. I didn't check how mature the topics
> were that caused errors.
Ok, it is in the next version I will send.

Thanks, Christian.

Previous: Beat BolliNext: Junio C Hamano
Message 5 of 8 in “Pedantic fixes for Apple clang”
  1. 0/2 Pedantic fixes for Apple clangBeat Bolli, Jul 24, 2018
  2. 2/2 remote-odb: un-inline function remote_odb_reinitBeat Bolli, Jul 24, 2018
  3. Jonathan NiederJul 24, 2018
  4. Beat BolliJul 24, 2018
  5. Christian CouderJul 25, 2018
  6. Junio C HamanoJul 25, 2018
  7. 1/2 packfile: drop a repeated enum declarationBeat Bolli, Jul 24, 2018
  8. Jonathan NiederJul 24, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.