Re: [PATCH 1/2] packfile: drop a repeated enum declaration

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 24, 2018, 21:57 UTC
Message-ID: <20180724215736.GC136514@aiede.svl.corp.google.com>
In-Reply-To: <20180724215223.27516-2-dev+git@drbeat.li>

Hi,

Beat Bolli wrote:

Show 10 quoted lines

> --- a/packfile.h
> +++ b/packfile.h
> @@ -6,7 +6,6 @@
>  /* in object-store.h */
>  struct packed_git;
>  struct object_info;
> -enum object_type;
>  
>  /*
>   * Generate the filename to be used for a pack file with checksum "sha1" and

Good catch. This means packfile.h should #include "cache.h" --- otherwise, it is not usable in a file that does

	#include "git-compat-util.h"
	#include "packfile.h"

Thanks and hope that helps, Jonathan