git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/5] ci: merge linux-gcc-default into linux-gcc

From
Christian Couder <christian.couder@gmail.com>
Date
Jan 7, 2025, 13:54 UTC
Message-ID
<CAP8UFD2MLfHVhz85sEJwJqhd-hFPUOm8b9eBSbjTgV=k966Tjw@mail.gmail.com>
In-Reply-To
<Z30ipNB88iyaWMBT@pks.im>
On Tue, Jan 7, 2025 at 1:48 PM Patrick Steinhardt <ps@pks.im> wrote:
Show 33 quoted lines
>
> On Mon, Jan 06, 2025 at 02:25:23PM +0100, Christian Couder wrote:
> > On Mon, Jan 6, 2025 at 8:51 AM Patrick Steinhardt <ps@pks.im> wrote:
> > >
> > > The "linux-gcc-default" job is mostly doing the same as the "linux-gcc"
> > > job, except for a couple of minor differences:
> > >
> > >   - We use an explicit GCC version instead of the default version
> > >     provided by the distribution. We have other jobs that test with
> > >     "gcc-8", making this distinction pointless.
> > >
> > >   - We don't set up the Python version explicitly, and instead use the
> > >     default Python version. Python 2 has been end-of-life for quite a
> > >     while now though, making this distinction less interesting.
> > >
> > >   - We set up the default branch name to be "main" in "linux-gcc". We
> > >     have other testcases that don't and also some that explicitly use
> > >     "master".
> > >
> > > So overall, the job does not add much to our test coverage. Merge it
> > > into our "linux-gcc" job to reduce our test matrix a bit.
> >
> > I understand that the subject uses "merge" as the space is limited
> > there, but it might be better to be a bit more explicit here about
> > what the patch is doing, which is:
> >
> >   - making the "linux-gcc" job use the default version of gcc provided
> > by the distribution (which is ubuntu-20.04) instead of "gcc-8",
> >   - removing the "linux-gcc-default" job.
>
> But isn't that what "merging" is about? One merges the diff of side A
> into B and then removes A. I don't have an idea for a better subject,
> honestly.

My comment was saying that it was fine to use "merge" in the subject, but that, in the body part of the commit message, it would be better if there were more details about what the commit is actually doing.

When the commit message is not clear about what the commit does, it's difficult to check that the changes in the commit were intended.

Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 17 of 47 in “remote: announce removal of "branches/" and "remotes/"”
  1. 0/5 remote: announce removal of "branches/" and "remotes/"Patrick Steinhardt, Dec 11, 2024
  2. 1/5 Makefile: wire up build option for deprecated featuresPatrick Steinhardt, Dec 11, 2024
  3. Kristoffer HaugsbakkDec 11, 2024
  4. Patrick SteinhardtDec 13, 2024
  5. 2/5 ci: merge linux-gcc-default into linux-gccPatrick Steinhardt, Dec 11, 2024
  6. 3/5 ci: repurpose "linux-gcc" job for deprecationsPatrick Steinhardt, Dec 11, 2024
  7. 4/5 builtin/pack-redundant: remove subcommand with breaking changesPatrick Steinhardt, Dec 11, 2024
  8. 5/5 remote: announce removal of "branches/" and "remotes/"Patrick Steinhardt, Dec 11, 2024
  9. 0/5 remote: announce removal of "branches/" and "remotes/"Patrick Steinhardt, Jan 6, 2025
  10. 1/5 Makefile: wire up build option for deprecated featuresPatrick Steinhardt, Jan 6, 2025
  11. Christian CouderJan 6, 2025
  12. Christian CouderJan 6, 2025
  13. 2/5 ci: merge linux-gcc-default into linux-gccPatrick Steinhardt, Jan 6, 2025
  14. Christian CouderJan 6, 2025
  15. Junio C HamanoJan 6, 2025
  16. Patrick SteinhardtJan 7, 2025
  17. Christian CouderJan 7, 2025
  18. 3/5 ci: repurpose "linux-gcc" job for deprecationsPatrick Steinhardt, Jan 6, 2025
  19. 4/5 builtin/pack-redundant: remove subcommand with breaking changesPatrick Steinhardt, Jan 6, 2025
  20. 5/5 remote: announce removal of "branches/" and "remotes/"Patrick Steinhardt, Jan 6, 2025
  21. Christian CouderJan 6, 2025
  22. Junio C HamanoJan 6, 2025
  23. Patrick SteinhardtJan 7, 2025
  24. Junio C HamanoJan 7, 2025
  25. Junio C HamanoJan 7, 2025
  26. rsbecker@nexbridge.comJan 7, 2025
  27. Patrick SteinhardtJan 8, 2025
  28. Junio C HamanoJan 8, 2025
  29. Patrick SteinhardtJan 9, 2025
  30. Robert CoupJan 9, 2025
  31. Patrick SteinhardtJan 9, 2025
  32. Junio C HamanoJan 9, 2025
  33. Junio C HamanoJan 6, 2025
  34. Patrick SteinhardtJan 7, 2025
  35. Junio C HamanoJan 7, 2025
  36. 0/5 remote: announce removal of "branches/" and "remotes/"Patrick Steinhardt, Jan 22, 2025
  37. 1/5 Makefile: wire up build option for deprecated featuresPatrick Steinhardt, Jan 22, 2025
  38. 2/5 ci: merge linux-gcc-default into linux-gccPatrick Steinhardt, Jan 22, 2025
  39. 3/5 ci: repurpose "linux-gcc" job for deprecationsPatrick Steinhardt, Jan 22, 2025
  40. 4/5 builtin/pack-redundant: remove subcommand with breaking changesPatrick Steinhardt, Jan 22, 2025
  41. 5/5 remote: announce removal of "branches/" and "remotes/"Patrick Steinhardt, Jan 22, 2025
  42. Junio C HamanoJan 22, 2025
  43. Jakub WilkFeb 21, 2025
  44. Junio C HamanoFeb 21, 2025
  45. Patrick SteinhardtFeb 25, 2025
  46. Junio C HamanoFeb 25, 2025
  47. Patrick SteinhardtFeb 26, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.