Re: [PATCH v2 5/5] remote: announce removal of "branches/" and "remotes/"

From: Christian Couder <christian.couder@gmail.com>
Date: Jan 6, 2025, 13:24 UTC
Message-ID: <CAP8UFD0Lzazxyq9nnT-vwN=MijKAsYySFC2dvDEj33cS7VB0kA@mail.gmail.com>
In-Reply-To: <20250106-pks-remote-branches-deprecation-v2-5-2ce87c053536@pks.im>

On Mon, Jan 6, 2025 at 8:52 AM Patrick Steinhardt <ps@pks.im> wrote:

>
> Back when Git was in its infancy, remotes were configured via separate
> files in "branches/" (back in 2005). This mechanism was replaced later
> that year with the "remotes/" directory. These mechanism have eventually

s/mechanism/mechanisms/

Show 6 quoted lines

> been replaced by config-based remotes, and it is very unlikely that
> anybody still uses these directories to configure their remotes.
>
> Both of these directories have been marked as deprecated, one in 2005
> and the other one in 2011. Follow through with the deprecation and
> finally announce the removal of these features in Git 3.0.

What I like about the removal of git-pack-redundant(1) in the previous patch is that we started to emit a user-visible warning in 2020 and now users even have to pass an `--i-still-use-this` option to be able to use the command. This really makes sure users cannot ignore the fact that the command is deprecated.

Accordingly I think it would be nice if we started to emit warnings (that could possibly be disabled) when we find a repo still uses stuff in "branches/" and "remotes/". These would be much more difficult to miss or ignore than doc changes.