git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t9700: fix test for perl older than 5.14

From
Christian Couder <christian.couder@gmail.com>
Date
Mar 4, 2016, 20:12 UTC
Message-ID
<CAP8UFD2Jh4NAaJ-1DPSUB5A00XqQNNhEq34oDP-Nqo0W2zKVhg@mail.gmail.com>
In-Reply-To
<1457094068.2660.85.camel@kaarsemaker.net>

On Fri, Mar 4, 2016 at 1:21 PM, Dennis Kaarsemaker <dennis@kaarsemaker.net> wrote:

Show 28 quoted lines
> On vr, 2016-03-04 at 06:43 -0500, Jeff King wrote:
>> On Fri, Mar 04, 2016 at 11:58:24AM +0100, Dennis Kaarsemaker wrote:
>>
>> > On vr, 2016-03-04 at 03:56 -0500, Jeff King wrote:
>> > > ? Those are just guesses, but if we are tickling a bug in perl's parser,
>> > > this might avoid them. I also wondered when "/r" appeared. It was in
>> > > 5.14, so you're presumably good there. The "use" statement at the top of
>> > > the script says "5.008", so perhaps we should be writing it out longhand
>> > > anyway (that version is "only" 5 years old, so I suspect there are still
>> > > systems around with 5.12 or older).
>> >
>> > Knowing the system Christian is testing on, I think the problem is that
>> > the tests are actually being run against perl 5.10, which RHEL 6 ships
>> > as system perl. As that's still a supported OS, writing tests in a form
>> > compatible with it would be a good thing :)
>>
>> That would make sense. `perl` in t9700-perl-git.sh (and all of our
>> scripts) is actually a shell function:
>>
>>   perl () {
>>           command "$PERL_PATH" "$@"
>>   }
>>
>> to make sure we respect PERL_PATH everywhere. And that defaults in the
>> Makefile to /usr/bin/perl. Christian presumably has 5.14 in his $PATH,
>> but /usr/bin/perl is the system 5.10.
>
> Yeah, that's how our systems are set up.
Yeah, you are both right.

Thanks for debugging this, Christian.

Previous: Dennis KaarsemakerNext: Johannes Schindelin
Message 8 of 10 in “t9700-perl-git.sh is broken on some configurations”
  1. Christian CouderMar 4, 2016
  2. Jeff KingMar 4, 2016
  3. Christian CouderMar 4, 2016
  4. Jeff KingMar 4, 2016
  5. Dennis KaarsemakerMar 4, 2016
  6. t9700: fix test for perl older than 5.14Jeff King, Mar 4, 2016
  7. Dennis KaarsemakerMar 4, 2016
  8. Christian CouderMar 4, 2016
  9. Johannes SchindelinMar 4, 2016
  10. Junio C HamanoMar 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.