Re: t9700-perl-git.sh is broken on some configurations

From: Jeff King <peff@peff.net>
Date: Mar 4, 2016, 11:45 UTC
Message-ID: <20160304114542.GB569@sigill.intra.peff.net>
In-Reply-To: <CAP8UFD3jZ2b8jgw8dR0U=AkPTTm5nO1F92UVjyeAMsfiOaJ_5w@mail.gmail.com>

On Fri, Mar 04, 2016 at 11:30:36AM +0100, Christian Couder wrote:

Show 8 quoted lines

> > Those are just guesses, but if we are tickling a bug in perl's parser,
> > this might avoid them. I also wondered when "/r" appeared. It was in
> > 5.14, so you're presumably good there.
> 
> If I just remove the "r" at the end of "s/\\/\//gr", I get with both
> Perl versions:
> 
> Can't modify non-lvalue subroutine call at t/t9700/test.pl line 36.

Right, because the string being operated on is the return value of a function, so we can't do substitution on it (unless with "r", whose purpose is to allow exactly such a thing).

Show 6 quoted lines

> > The "use" statement at the top of
> > the script says "5.008", so perhaps we should be writing it out longhand
> > anyway (that version is "only" 5 years old, so I suspect there are still
> > systems around with 5.12 or older).
> 
> Yeah, it would work.

Thanks for confirming the longhand does work; I think the patch I just posted elsewhere in the thread should be good for you, then.

-Peff