Re: [Outreachy] [PATCH] bisect--helper: avoid free-after-use

From: Christian Couder <christian.couder@gmail.com>
Date: Dec 9, 2019, 10:22 UTC
Message-ID: <CAP8UFD2C0uh+e_tH2H=z2RqDwSC7SEu-JoBx3z2KefVND8OqYQ@mail.gmail.com>
In-Reply-To: <20191209084022.18650-1-mirucam@gmail.com>

Hi Miriam,

As Dscho suggests, next time please use [PATCH v2] or [PATCH v3] instead of [PATCH] if the patch has already been sent, even if the subject has changed.

On Mon, Dec 9, 2019 at 9:40 AM Miriam Rubio <mirucam@gmail.com> wrote:

Show 11 quoted lines

>
> From: Tanushree Tumane <tanushreetumane@gmail.com>
>
> In 5e82c3dd22a (bisect--helper: `bisect_reset` shell function in C,
> 2019-01-02), the `git bisect reset` subcommand was ported to C. When the
> call to `git checkout` failed, an error message was reported to the
> user.
>
> However, this error message used the `strbuf` that had just been
> released already. Let's switch that around: first use it, then release
> it.

Great!

I think keeping Tanushree as the author and changing the commit message and the subject was the right thing to do.

Show 5 quoted lines

> Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
> Signed-off-by: Miriam Rubio <mirucam@gmail.com>
> ---

Here (after the line starting with "---") you can add comments about the patch. One useful comment here would be to say that this patch is a new version of https://public-inbox.org/git/20191208172813.16518-1-mirucam@gmail.com/ which itself has been sent previously by Tanushree (https://public-inbox.org/git/64117cde718f0d56ebfa4c30f4d8fe2155f5cf65.1551003074.git.gitgitgadget@gmail.com/).

Thanks, Christian.