Re: [Outreachy] [PATCH] bisect--helper: avoid free-after-use

From: Christian Couder <christian.couder@gmail.com>
Date: Dec 9, 2019, 11:10 UTC
Message-ID: <CAP8UFD1ExQ=hmLK8Sakceh8h9uytF+rVpC_YX3ze0M2LMU+2cw@mail.gmail.com>
In-Reply-To: <CAN7CjDCU=BPA3n6aDEPEzV8VK=JtYFn5_3CbqYrc5Zpg79m5jw@mail.gmail.com>

On Mon, Dec 9, 2019 at 11:36 AM Miriam R. <mirucam@gmail.com> wrote:

Show 14 quoted lines

> > > Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> > > Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> > > Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
> > > Signed-off-by: Miriam Rubio <mirucam@gmail.com>
> > > ---
> >
> > Here (after the line starting with "---") you can add comments about
> > the patch. One useful comment here would be to say that this patch is
> > a new version of
> > https://public-inbox.org/git/20191208172813.16518-1-mirucam@gmail.com/
> > which itself has been sent previously by Tanushree
> > (https://public-inbox.org/git/64117cde718f0d56ebfa4c30f4d8fe2155f5cf65.1551003074.git.gitgitgadget@gmail.com/).
> >
> Ok, I'll resend another one (v2) adding this comments. :)

It's not a big deal, but there was no need to resend another one, as the comment is there only to help reviewers with extra information related to where the patch comes from. It will not appear in the commit that will be made from the patch (using `git am`) and I already gave the information about where the patch comes from in my reply to the patch.