Re: [PATCH v4 0/4] Test oidmap
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Jun 19, 2019, 22:25 UTC
- Message-ID
- <CAP8UFD2=_q==e0UxFyHrZS-Bue36PDow28DpFBURnkG=0brUcQ@mail.gmail.com>
- In-Reply-To
- <20190619220925.GF6571@sigill.intra.peff.net>
On Thu, Jun 20, 2019 at 12:09 AM Jeff King <peff@peff.net> wrote:
Show 6 quoted lines
> > On Wed, Jun 19, 2019 at 05:42:13PM -0400, Jeff King wrote: > > > I do think that sha1hash() will eventually go away in favor of > > oidhash(), but we can approach that separately, and convert oidmap along > > with everyone else.
Yeah, deprecating it is a different topic.
Show 15 quoted lines
> > It looks like we are close to being able to do that now. Grepping for > > sha1hash shows just about everybody dereferencing an oid object, except > > for the call in pack-objects.c. And skimming the callers there, > > they all appear to have an oid object, too. > > Actually, it does get a little tangled, as our khash implementation also > uses sha1hash (though IMHO that should become oidhash, too). There's > also some preparatory work needed in pack-objects, which I've pushed up > to: > > https://github.com/peff/git jk/drop-sha1hash > > I got interrupted and may try to resume this cleanup later; mostly I > wanted to post something now so you did not duplicate what I'd already > done.
Thanks for your work on that, Christian.