[PATCH 10/17] khash: drop broken oid_map typedef
- From
Jeff King <peff@peff.net>
- Date
- Jun 20, 2019, 07:41 UTC
- Message-ID
- <20190620074124.GJ3713@sigill.intra.peff.net>
- In-Reply-To
- <20190620073952.GA1539@sigill.intra.peff.net>
Commit 5a8643eff1 (khash: move oid hash table definition, 2019-02-19) added a khash "oid_map" type to match the existing "oid" type, which is a simple set (i.e., just keys, no values). But in setting up the khash_oid_map typedef, it accidentally referred to "kh_oid_t", which is the set type.
Nobody noticed the breakage because there are not yet any callers; the type was added just as a match to the existing sha1 types (whose map type confusingly _is_ called khash_sha1, and it has no matching set type).
We could easily fix this with s/oid/oid_map/ in the typedef. But let's take this a step further, and just drop the typedef entirely. These typedefs were added by 5a8643eff1 to match the khash_sha1 typedefs. But the actual khash-derived type names are descriptive enough; this is just adding an extra layer of indirection. The khash names do not quite follow our usual style (e.g., they end in "_t"), but since we end up using other khash names (e.g., khiter_t, kh_get_oid()) anyway, just typedef-ing the struct name is not really helping much.
And there are already many cases where we use the raw khash type names anyway (e.g., the "set" variant defined just above us does not have such a typedef!).
So let's drop this typedef, and the matching oid_pos one (which actually _does_ have a user, but we can easily convert it).
We'll leave the khash_sha1 typedef around. The ultimate fate of its callers should be conversion to kh_oid_map_t, so there's no point in going through the noise of changing the names now.
Signed-off-by: Jeff King <peff@peff.net> --- khash.h | 2 -- pack-bitmap.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/khash.h b/khash.h index af747a683f..64d4eeb2bd 100644 --- a/khash.h +++ b/khash.h @@ -345,9 +345,7 @@ static inline int oid_equal(struct object_id a, struct object_id b) KHASH_INIT(oid, struct object_id, int, 0, oid_hash, oid_equal) KHASH_INIT(oid_map, struct object_id, void *, 1, oid_hash, oid_equal) -typedef kh_oid_t khash_oid_map; KHASH_INIT(oid_pos, struct object_id, int, 1, oid_hash, oid_equal) -typedef kh_oid_pos_t khash_oid_pos; #endif /* __AC_KHASH_H */ diff --git a/pack-bitmap.c b/pack-bitmap.c index ff1f07e249..998133588f 100644 --- a/pack-bitmap.c +++ b/pack-bitmap.c @@ -365,7 +365,7 @@ struct include_data { static inline int bitmap_position_extended(struct bitmap_index *bitmap_git, const struct object_id *oid) { - khash_oid_pos *positions = bitmap_git->ext_index.positions; + kh_oid_pos_t *positions = bitmap_git->ext_index.positions; khiter_t pos = kh_get_oid_pos(positions, *oid); if (pos < kh_end(positions)) {
-- 2.22.0.732.g5402924b4b