Re: [PATCH v5 0/6] fast-export, fast-import: add support for signed-commits

From: Christian Couder <christian.couder@gmail.com>
Date: Mar 10, 2025, 15:59 UTC
Message-ID: <CAP8UFD1m2Lb=e-gQgR_oT7u67-S0_XY=OebOiRq6Tnn3g9-pkQ@mail.gmail.com>
In-Reply-To: <xmqqikoyklo9.fsf@gitster.g>

On Tue, Feb 25, 2025 at 5:56 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

>
> Elijah Newren <newren@gmail.com> writes:
>
> >> This is also exactly the usecase we have been reviving this effort for
> >> :) We recently hit such a case where a customer was basically unable to
> >> use git-filter-repo(1) due to commit signatures, so we wanted to help
> >> out and get this patch series landed so that the issue can ultimately be
> >> addressed in git-filter-repo(1).
> >
> > I'm confused; this patch series doesn't implement the option Junio and
> > I were talking about.  It only allows existing signatures to be
> > carried as-is, as opposed to resigning all the commits with the
> > current user's signature.
>
> I read the "can ultimately be" as "this series lays the groundwork
> by upstreaming what the earlier effort started and stops there. a
> future follow-up work will build on this to add more".

Yeah, this is our goal. I have added the following section to the cover letter to clarify this:

Big picture goal ~~~~~~~~~~~~~~~~

Independent from these --signed-tags/--signed-commits options addressed in this series, we want to have an option, that allows the person who performed the import to attest to the result by adding their own signature on tags and commits, whether these tags and commits were originally signed or not.

This series lays the groundwork for that future option by upstreaming the earlier effort started by Luke Shumaker and stops there. Future follow-up work will build on it towards the big picture goal.