Re: [PATCH v3 3/3] fast-export, fast-import: implement signed-commits

From: Luke Shumaker <lukeshu@lukeshu.com>
Date: Apr 30, 2021, 19:34 UTC
Message-ID: <87a6pfpnvt.wl-lukeshu@lukeshu.com>
In-Reply-To: <xmqqfszbcazc.fsf@gitster.g>

On Tue, 27 Apr 2021 22:02:47 -0600, Junio C Hamano wrote:

Show 6 quoted lines

> Better yet, don't butcher the region of memory pointed by the
> "message" variable the caller uses to keep reading from the
> remainder of the commit object buffer with this and memmove()
> below.  Perhaps have the caller pass a strbuf to fill in the
> signature found by this helper as another parameter, and then return
> a bool "Yes, I found a sig" as its return value?

Stupid question: is there a better way to append a region of bytes to a strbuf than

    strbuf_addf(&buf, "%.*s", (int)(str_end - str_beg), str);

It seems weird to me to invoke the printf machinery for something so simple, but I don't see anything alternatives in strbuf.h. Am I missing something?

-- 
Happy hacking,
~ Luke Shumaker