Re: [PATCH v2 1/8] make_transient_cache_entry(): optionally alloc from mem_pool

From: Christian Couder <christian.couder@gmail.com>
Date: May 1, 2021, 17:06 UTC
Message-ID: <CAP8UFD1dz=u-nXyxSKArP-fAiX6mq3FV+oiiKCHCqbWMMf4TWw@mail.gmail.com>
In-Reply-To: <f870040bfb3e73ee8cd27352b0acc65bb54be560.1619818517.git.matheus.bernardino@usp.br>

Show 5 quoted lines

>  struct cache_entry *make_transient_cache_entry(unsigned int mode,
>                                                const struct object_id *oid,
>                                                const char *path,
> -                                              int stage);
> +                                              int stage, struct mem_pool *mp);

It's a bit strange that `int stage` isn't on its own line here, as other parameters are. And if line length was the issue, it looks like it could have been on the same line as `const char *path`.

Show 5 quoted lines

> -struct cache_entry *make_transient_cache_entry(unsigned int mode, const struct object_id *oid,
> -                                              const char *path, int stage)
> +struct cache_entry *make_transient_cache_entry(unsigned int mode,
> +                                              const struct object_id *oid,
> +                                              const char *path, int stage,

Here also, it's a bit strange that `int stage` isn't on its own line, as it looks like you want to put others parameters on their own line. And this is not consistent with the above declaration.

> +                                              struct mem_pool *mp)