Re: [PATCH v2 2/8] builtin/checkout.c: complete parallel checkout support

From

Christian Couder <christian.couder@gmail.com>

Date

May 1, 2021, 17:08 UTC

Message-ID

<CAP8UFD16N3MiYawrRLCxsrYuo4KkvD3SS5F4UqyEF37j4T9yVA@mail.gmail.com>

In-Reply-To

<e2d82c4337dc002d7296454c59d4006c3bb43c27.1619818517.git.matheus.bernardino@usp.br>

>
> Pathspec-limited checkouts (like `git checkout *.txt`) are performed by
> a code path that doesn't yet support parallel checkout because it calls
> checkout_entry() directly, instead of unpack_trees(). Let's add parallel
> checkout support for this code path too.
>
> Note: the transient cache entries allocated in checkout_merged() are now

s/Note: the/The/

> allocated in a mem_pool which is only discarded after parallel checkout
> finishes. This is done because the entries need to be valid when
> run_parallel_checkout() is called.

> -static int checkout_merged(int pos, const struct checkout *state, int *nr_checkouts)
> +static int checkout_merged(int pos, const struct checkout *state,
> +                          int *nr_checkouts, struct mem_pool *ce_mem_pool)

For consistency with the previous patch, maybe: s/ce_mem_pool/ce_mp/