Re: [PATCH v4 3/7] builtin/gc: move pruning of worktrees into a separate function

From: Christian Couder <christian.couder@gmail.com>
Date: May 6, 2025, 07:50 UTC
Message-ID: <CAP8UFD1ZtYMf0ja75AV_jGJgzAL919zpHoGy0v-G2tNV+OEDwA@mail.gmail.com>
In-Reply-To: <20250505-pks-maintenance-missing-tasks-v4-3-141f4df906a1@pks.im>

On Mon, May 5, 2025 at 10:52 AM Patrick Steinhardt <ps@pks.im> wrote:

>
> Move pruning of worktrees into a separate function.

Repeating the subject at the beginning of the body part of the commit message doesn't bring much value.

> This prepares for a
> subsequent commit where we introduce a new "worktree-prune" task for
> git-maintenance(1).

I think it might help a bit to reword in the usual "describe the problem first and then say what to do about it" way. Maybe something like:

"In a subsequent commit we are going to introduce a new "worktree-prune" task for git-maintenance(1).

To prepare for this, refactor the code that prunes worktrees into a separate function."