Re: [PATCH v4 0/7] builtin/maintenance: implement missing tasks compared to git-gc(1)

From: Christian Couder <christian.couder@gmail.com>
Date: May 6, 2025, 09:05 UTC
Message-ID: <CAP8UFD0twBxZvEiLq8OBi2xhT+BnbL2k7swqru5CTQ67rdYM3Q@mail.gmail.com>
In-Reply-To: <20250505-pks-maintenance-missing-tasks-v4-0-141f4df906a1@pks.im>

On Mon, May 5, 2025 at 10:52 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 6 quoted lines

> Changes in v4:
>   - simplified the heuristic for "rerere-gc" even further. A positive
>     value for "maintenance.rerere-gc.auto" now indicates that the
>     command will run whenever there is at least one directory entry in
>     ".rr-cache". The exact value does not matter anymore.
>   - Link to v3: https://lore.kernel.org/r/20250502-pks-maintenance-missing-tasks-v3-0-13e130d36640@pks.im

Except for a few nits I commented on in my replies to specific patches, and except that some comments from Eric Sunshine in https://lore.kernel.org/git/CAPig+cScor=E2i4w99NCrsaUd-Po=FqhkrLSyT69PSo1+h2dRw@mail.gmail.com/#t seems to have been overlooked (especially one about a memory leak), this looks good to me.

Thanks!