git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 02/11] trailer: process trailers from stdin and arguments

From
Christian Couder <christian.couder@gmail.com>
Date
Mar 7, 2014, 12:41 UTC
Message-ID
<CAP8UFD1RF79YpdORs7_HNYDOufwPEoRj62YRvyL9Pp7j5YAPCA@mail.gmail.com>
In-Reply-To
<20140307080850.GC4774@mwanda>
On Fri, Mar 7, 2014 at 9:08 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
Show 10 quoted lines
> On Fri, Mar 07, 2014 at 07:19:15AM +0100, Christian Couder wrote:
>>
>> Yeah, I don't know why, but these days I find it very hard to review
>> style issues in my own code without being distracted.
>> And by the way is there a good script to check them?
>
> Many of these would have been caught with kernel.org's checkpatch.pl
> script.
>
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl

Yeah, I already thought about using it in the past, but I was not sure about its status regarding the git source code because it's use is not suggested in CodingGuidelines, and the discussions about adding it there went nowhere:

http://thread.gmane.org/gmane.comp.version-control.git/223698/focus=224653

Thanks, Christian.

Previous: Dan CarpenterNext: Christian Couder
Message 7 of 21 in “Add interpret-trailers builtin”
  1. 00/11 Add interpret-trailers builtinChristian Couder, Mar 4, 2014
  2. 01/11 Add data structures and basic functions for commit trailersChristian Couder, Mar 4, 2014
  3. 02/11 trailer: process trailers from stdin and argumentsChristian Couder, Mar 4, 2014
  4. Junio C HamanoMar 5, 2014
  5. Christian CouderMar 7, 2014
  6. Dan CarpenterMar 7, 2014
  7. Christian CouderMar 7, 2014
  8. 03/11 trailer: read and process config informationChristian Couder, Mar 4, 2014
  9. 04/11 trailer: process command line trailer argumentsChristian Couder, Mar 4, 2014
  10. Junio C HamanoMar 5, 2014
  11. 05/11 trailer: parse trailers from stdinChristian Couder, Mar 4, 2014
  12. Junio C HamanoMar 5, 2014
  13. 06/11 trailer: put all the processing together and printChristian Couder, Mar 4, 2014
  14. 07/11 trailer: add interpret-trailers commandChristian Couder, Mar 4, 2014
  15. 08/11 trailer: add tests for "git interpret-trailers"Christian Couder, Mar 4, 2014
  16. Junio C HamanoMar 5, 2014
  17. 09/11 trailer: execute command from 'trailer.<name>.command'Christian Couder, Mar 4, 2014
  18. Junio C HamanoMar 5, 2014
  19. 10/11 trailer: add tests for commands in config fileChristian Couder, Mar 4, 2014
  20. 11/11 Documentation: add documentation for 'git interpret-trailers'Christian Couder, Mar 4, 2014
  21. Ramsay JonesMar 6, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.