From: Christian Couder Date: Fri, 07 Mar 2014 12:41:38 GMT Subject: Re: [PATCH v6 02/11] trailer: process trailers from stdin and arguments Message-ID: In-Reply-To: <20140307080850.GC4774@mwanda> On Fri, Mar 7, 2014 at 9:08 AM, Dan Carpenter wrote: > On Fri, Mar 07, 2014 at 07:19:15AM +0100, Christian Couder wrote: >> >> Yeah, I don't know why, but these days I find it very hard to review >> style issues in my own code without being distracted. >> And by the way is there a good script to check them? > > Many of these would have been caught with kernel.org's checkpatch.pl > script. > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl Yeah, I already thought about using it in the past, but I was not sure about its status regarding the git source code because it's use is not suggested in CodingGuidelines, and the discussions about adding it there went nowhere: http://thread.gmane.org/gmane.comp.version-control.git/223698/focus=224653 Thanks, Christian.