git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] bisect--helper: avoid segfault with bad syntax in `start --term-*`

From
Christian Couder <christian.couder@gmail.com>
Date
May 22, 2020, 15:49 UTC
Message-ID
<CAP8UFD1Oa6g4kj8GDhDC-3ry1eFyg-aD+JVDtfK1TkJKuL8v-Q@mail.gmail.com>
In-Reply-To
<20200520232627.30901-1-carenas@gmail.com>

On Thu, May 21, 2020 at 1:31 AM Carlo Marcelo Arenas Belón <carenas@gmail.com> wrote:

Show 11 quoted lines
>
> 06f5608c14 (bisect--helper: `bisect_start` shell function partially in C,
> 2019-01-02) adds a lax parser for `git bisect start` which could result
> in a segfault under a bad syntax call for start with custom terms.
>
> Detect if there are enough arguments left in the command line to use for
> --term-{old,good,new,bad} and abort with the same syntax error the original
> implementation will show if not.
>
> While at it, remove an unnecessary (and incomplete) check for unknown
> arguments and make sure to add a test to avoid regressions.
This looks good to me!

Thanks, Christian.

Previous: Carlo Marcelo Arenas BelónNext: Junio C Hamano
Message 5 of 6 in “bisect--helper: avoid segfault with bad syntax in start --term-.+”
  1. bisect--helper: avoid segfault with bad syntax in start --term-.+Carlo Marcelo Arenas Belón, May 20, 2020
  2. Junio C HamanoMay 20, 2020
  3. Eric SunshineMay 20, 2020
  4. bisect--helper: avoid segfault with bad syntax in `start --term-*`Carlo Marcelo Arenas Belón, May 20, 2020
  5. Christian CouderMay 22, 2020
  6. Junio C HamanoMay 24, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.