From: Christian Couder <christian.couder@gmail.com>
Date: Fri, 22 May 2020 15:49:08 GMT
Subject: Re: [PATCH v2] bisect--helper: avoid segfault with bad syntax in `start --term-*`
Message-ID: <CAP8UFD1Oa6g4kj8GDhDC-3ry1eFyg-aD+JVDtfK1TkJKuL8v-Q@mail.gmail.com>
In-Reply-To: <20200520232627.30901-1-carenas@gmail.com>

On Thu, May 21, 2020 at 1:31 AM Carlo Marcelo Arenas Belón
<carenas@gmail.com> wrote:
>
> 06f5608c14 (bisect--helper: `bisect_start` shell function partially in C,
> 2019-01-02) adds a lax parser for `git bisect start` which could result
> in a segfault under a bad syntax call for start with custom terms.
>
> Detect if there are enough arguments left in the command line to use for
> --term-{old,good,new,bad} and abort with the same syntax error the original
> implementation will show if not.
>
> While at it, remove an unnecessary (and incomplete) check for unknown
> arguments and make sure to add a test to avoid regressions.

This looks good to me!

Thanks,
Christian.