Re: [GSoC] My project blog

From: Christian Couder <christian.couder@gmail.com>
Date: Aug 6, 2019, 07:16 UTC
Message-ID: <CAP8UFD1HgjcQDS2ypJVe_r3-Jpy1ENNGR+kCfa72Kmht28ZNJw@mail.gmail.com>
In-Reply-To: <CAHd-oW7pT=RhsCnkhRzGDy1gXWN7a4AnwdYCNa6q6uri1O51FQ@mail.gmail.com>

Hi Matheus,

On Tue, Aug 6, 2019 at 4:54 AM Matheus Tavares Bernardino <matheus.bernardino@usp.br> wrote:

>
> Here's my report from last week:
> https://matheustavares.gitlab.io/posts/week-11-wip-grep-protecting-textconv-and-submodules

Thank you for another great report!

Show 5 quoted lines

> I'm working to protect the operations I left behind on the first
> version of the patchset[1]. And for that, I used a lot of the code Duy
> provided[2] me as an example in the early days of this project. The
> race conditions are now majorly gone, but the patches still need some
> refactoring and there are still some problems to overcome.

This looks good to me! I think you are now way past the point where you know much more about this than me, but anyway the following might give you some ideas or perhaps in some other ways help you:

  - About "Try to remove the obj_read_lock", which is the last point
on your TODO list, it doesn't look necessary before you submit a patch
series, unless there is no performance improvement without it. You
could, as far as I can tell, do it in a later patch series.

  - I guess " --recurse-submodules" is not used very often with git
grep. For example I never use it on the Git repo even when I perhaps
should. So if it would simplify things to just disable the
improvements you made when " --recurse-submodules" is used, then you
might consider doing that. You could later send another patch series
that would enable your improvements when " --recurse-submodules" is
used.

Thanks, Christian.