git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC] My project blog

From
Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date
Aug 8, 2019, 14:22 UTC
Message-ID
<CAHd-oW5FYLnTp-_y7hAVOYUj=ugY3jGoqpWC_SVoKmfjwqf9=A@mail.gmail.com>
In-Reply-To
<CAP8UFD1HgjcQDS2ypJVe_r3-Jpy1ENNGR+kCfa72Kmht28ZNJw@mail.gmail.com>

On Tue, Aug 6, 2019 at 4:16 AM Christian Couder <christian.couder@gmail.com> wrote:

Show 33 quoted lines
>
> Hi Matheus,
>
> On Tue, Aug 6, 2019 at 4:54 AM Matheus Tavares Bernardino
> <matheus.bernardino@usp.br> wrote:
> >
> > Here's my report from last week:
> > https://matheustavares.gitlab.io/posts/week-11-wip-grep-protecting-textconv-and-submodules
>
> Thank you for another great report!
>
> > I'm working to protect the operations I left behind on the first
> > version of the patchset[1]. And for that, I used a lot of the code Duy
> > provided[2] me as an example in the early days of this project. The
> > race conditions are now majorly gone, but the patches still need some
> > refactoring and there are still some problems to overcome.
>
> This looks good to me! I think you are now way past the point where
> you know much more about this than me, but anyway the following might
> give you some ideas or perhaps in some other ways help you:
>
>   - About "Try to remove the obj_read_lock", which is the last point
> on your TODO list, it doesn't look necessary before you submit a patch
> series, unless there is no performance improvement without it. You
> could, as far as I can tell, do it in a later patch series.
>
>   - I guess " --recurse-submodules" is not used very often with git
> grep. For example I never use it on the Git repo even when I perhaps
> should. So if it would simplify things to just disable the
> improvements you made when " --recurse-submodules" is used, then you
> might consider doing that. You could later send another patch series
> that would enable your improvements when " --recurse-submodules" is
> used.

Thanks for the suggestions, Christian. So, I think I could finish and send the patchset without the optimization for --recurse-submodules and --textconv, while I don't finish support for them, right? And I think 'obj_read_lock' may be removed in a future patch, as you said, because we already have good speedup without removing it. Finally, should I also add a "NOTES" section to Documentation/git-grep.txt saying which options --threads is not compatible with?

Thanks, Matheus

Previous: Christian CouderNext: Matheus Tavares Bernardino
Message 9 of 16 in “[GSoC] My project blog”
  1. Matheus Tavares BernardinoJul 3, 2019
  2. Matheus Tavares BernardinoJul 14, 2019
  3. Christian CouderJul 14, 2019
  4. Matheus Tavares BernardinoJul 14, 2019
  5. Matheus Tavares BernardinoJul 23, 2019
  6. Matheus Tavares BernardinoJul 29, 2019
  7. Matheus Tavares BernardinoAug 6, 2019
  8. Christian CouderAug 6, 2019
  9. Matheus Tavares BernardinoAug 8, 2019
  10. Matheus Tavares BernardinoAug 13, 2019
  11. Christian CouderAug 13, 2019
  12. Matheus Tavares BernardinoAug 20, 2019
  13. Olga TelezhnayaAug 20, 2019
  14. Christian CouderAug 20, 2019
  15. Matheus Tavares BernardinoAug 20, 2019
  16. Matheus Tavares BernardinoAug 27, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.