git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 7/8] t0410: test fetching from many promisor remotes

From
Christian Couder <christian.couder@gmail.com>
Date
Sep 28, 2018, 11:43 UTC
Message-ID
<CAP8UFD1HBUL+Kv7biBLwfkL9j9syw+UwBgrJ5rAykZ-M5h8jbg@mail.gmail.com>
In-Reply-To
<20180928103548.GC23446@localhost>
On Fri, Sep 28, 2018 at 12:35 PM SZEDER Gábor <szeder.dev@gmail.com> wrote:
>
> On Tue, Sep 25, 2018 at 01:53:40PM +0200, Christian Couder wrote:
Show 10 quoted lines
> > +     IDX=$(cat promisorlist | sed "s/promisor$/idx/") &&
>
> You could drop the unnecessary 'cat', 'sed' is capable to open a file
> on its own.
>
> > +     git verify-pack --verbose "$IDX" | grep "$HASH2"
>
> Don't run a git command, especially one with "verify" in its name,
> upstream of a pipe, because the pipe hides the git command's exit
> code.

Yeah, I copied both of the above lines from the test just above the one I added. So I will probably add a patch to fix those kinds of issues in t0410 at the beginning of the series, and then of course copy the fixed tests in the tests I add.

Thanks, Christian.

Previous: SZEDER Gábor
Message 12 of 12 in “Introducing remote ODBs”
  1. 0/8 Introducing remote ODBsChristian Couder, Sep 25, 2018
  2. 1/8 fetch-object: make functions return an error codeChristian Couder, Sep 25, 2018
  3. 2/8 Add initial remote odb supportChristian Couder, Sep 25, 2018
  4. 3/8 remote-odb: implement remote_odb_get_direct()Christian Couder, Sep 25, 2018
  5. 4/8 remote-odb: add remote_odb_reinit()Christian Couder, Sep 25, 2018
  6. 6/8 Use odb.origin.partialclonefilter instead of core.partialclonefilterChristian Couder, Sep 25, 2018
  7. 5/8 Use remote_odb_get_direct() and has_remote_odb()Christian Couder, Sep 25, 2018
  8. 8/8 Documentation/config: add odb.<name>.promisorRemoteChristian Couder, Sep 25, 2018
  9. Duy NguyenSep 25, 2018
  10. 7/8 t0410: test fetching from many promisor remotesChristian Couder, Sep 25, 2018
  11. SZEDER GáborSep 28, 2018
  12. Christian CouderSep 28, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.