From: Christian Couder <christian.couder@gmail.com>
Date: Fri, 28 Sep 2018 11:43:30 GMT
Subject: Re: [PATCH v5 7/8] t0410: test fetching from many promisor remotes
Message-ID: <CAP8UFD1HBUL+Kv7biBLwfkL9j9syw+UwBgrJ5rAykZ-M5h8jbg@mail.gmail.com>
In-Reply-To: <20180928103548.GC23446@localhost>

On Fri, Sep 28, 2018 at 12:35 PM SZEDER Gábor <szeder.dev@gmail.com> wrote:
>
> On Tue, Sep 25, 2018 at 01:53:40PM +0200, Christian Couder wrote:

> > +     IDX=$(cat promisorlist | sed "s/promisor$/idx/") &&
>
> You could drop the unnecessary 'cat', 'sed' is capable to open a file
> on its own.
>
> > +     git verify-pack --verbose "$IDX" | grep "$HASH2"
>
> Don't run a git command, especially one with "verify" in its name,
> upstream of a pipe, because the pipe hides the git command's exit
> code.

Yeah, I copied both of the above lines from the test just above the
one I added. So I will probably add a patch to fix those kinds of
issues in t0410 at the beginning of the series, and then of course
copy the fixed tests in the tests I add.

Thanks,
Christian.