Re: [PATCH v3 0/1] ref-filter: add new "signature" atom

From: Christian Couder <christian.couder@gmail.com>
Date: Jan 10, 2023, 09:13 UTC
Message-ID: <CAP8UFD1A8BofxHZP5cJ-xcQA8rbfoLN50hMc-dfUYUOGKqA65A@mail.gmail.com>
In-Reply-To: <20230110005251.10539-1-nsengiyumvawilberforce@gmail.com>

On Tue, Jan 10, 2023 at 1:53 AM Nsengiyumva Wilberforce <nsengiyumvawilberforce@gmail.com> wrote:

Show 7 quoted lines

>  Documentation/git-for-each-ref.txt |  27 +++++++
>  ref-filter.c                       | 101 +++++++++++++++++++++++++
>  t/t6300-for-each-ref.sh            | 116 +++++++++++++++++++++++++++++
>  3 files changed, 244 insertions(+)
>
> Range-diff against v2:
> 1:  ce51d8e79e = 1:  ce51d8e79e ref-filter: add new "signature" atom

It's strange that it's saying nothing changed compared to v2. I guess the v2 it's talking about is not actually the v2 you sent to the list, right?

Anyway it's better if you can describe a bit with your own words in the cover letter what changed, and sometimes even what didn't change, since the previous version you sent.

For example, here you can say that you decided to actually remove the test that checked the %(signature) format and explain a bit the reason why you did that.

You can also send links in the cover letter to the branch(es) (on GitHub, GitLab or other such platforms) that you used for this and previous versions of the patch (or patch series). It can help people try it and look at the changes on their own system.

Thanks.