git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 0/1] ref-filter: add new "signature" atom

From
Nsengiyumva Wilberforce <nsengiyumvawilberforce@gmail.com>
Date
Jan 16, 2023, 17:38 UTC
Message-ID
<20230116173814.11338-1-nsengiyumvawilberforce@gmail.com>
In-Reply-To
<20230110005251.10539-2-nsengiyumvawilberforce@gmail.com>

This patch is not different from previous version(3), this is because the previous version(3) could not show the difference from version(2) of the patch. I will explain every change from the first version <https://public-inbox.org/git/pull.1452.git.1672102523902.gitgitgadget@gmail.com/> to version 3 <https://public-inbox.org/git/20230110005251.10539-1-nsengiyumvawilberforce@gmail.com/> because I first had a big trouble in transitioning from gitgitgadget to using git send-mail

***THE FOLLOWING ARE THE CHANGES*** a) From the first version to version 2 <https://public-inbox.org/git/pull.1428.git.git.1673254961028.gitgitgadget@gmail.com/> Version 2 addresses all Junio's comments for version 1, the comments are here. <https://public-inbox.org/git/xmqqo7rpvb83.fsf@gitster.g/> ->summary of the changes i) I changed the commit message to detail more about the feature I am introducing. ii) Introduced a new helper function in ref-filter.c called parse_signature_option() and handled !arg case first. iii) Used the above helper function to eliminate the repetition that was in grab_signature() for checking different signature option. iv) I also moved check_commit_signature(commit, &sigc) out of the to avoid running GPG twice.still this change is in grab_signature() in ref-filter.c. v) add a new test in t6300 to test bare signature atom(%(signature)) since I had missed it

NB: I did not change the parser function name as he suggested, I
think my commit message was misleading.

b) from version 2 to version 3 <https://public-inbox.org/git/20230110005251.10539-2-nsengiyumvawilberforce@gmail.com/>

->summary of changes i) Got rid of test for bare signature atom. This is because the test was passing for some CI tests(different machines) and some others were failing.

Best Regards, Wilberforce

Nsengiyumva Wilberforce (1):
  ref-filter: add new "signature" atom
 Documentation/git-for-each-ref.txt |  27 +++++++
 ref-filter.c                       | 101 +++++++++++++++++++++++++
 t/t6300-for-each-ref.sh            | 116 +++++++++++++++++++++++++++++
 3 files changed, 244 insertions(+)

Range-diff against v3: 1: ce51d8e79e = 1: ce51d8e79e ref-filter: add new "signature" atom

-- 
2.39.0.138.gb334f1a8b9
Previous: Nsengiyumva WilberforceNext: Nsengiyumva Wilberforce
Message 10 of 19 in “ref-filter: add new atom "signature" atom”
  1. ref-filter: add new atom "signature" atomnsengaw4c via GitGitGadget, Dec 27, 2022
  2. Junio C HamanoDec 27, 2022
  3. NSENGIYUMVA WILBERFORCEJan 2, 2023
  4. Christian CouderJan 2, 2023
  5. Junio C HamanoJan 3, 2023
  6. Jeff KingDec 27, 2022
  7. NSENGIYUMVA WILBERFORCEJan 2, 2023
  8. 0/1 ref-filter: add new "signature" atomNsengiyumva Wilberforce, Jan 10, 2023
  9. 1/1 ref-filter: add new "signature" atomNsengiyumva Wilberforce, Jan 10, 2023
  10. 0/1 ref-filter: add new "signature" atomNsengiyumva Wilberforce, Jan 16, 2023
  11. 1/1 ref-filter: add new "signature" atomNsengiyumva Wilberforce, Jan 16, 2023
  12. 0/1 ref-filter: add new "signature" atomNsengiyumva Wilberforce, Mar 11, 2023
  13. 1/1 ref-filter: add new "signature" atomNsengiyumva Wilberforce, Mar 11, 2023
  14. Junio C HamanoMar 14, 2023
  15. Kousik SanagavarapuApr 28, 2023
  16. Kousik SanagavarapuApr 29, 2023
  17. Junio C HamanoJan 26, 2023
  18. Christian CouderJan 10, 2023
  19. NSENGIYUMVA WILBERFORCEJan 8, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.