Re: [PATCH v3 04/11] update-index: add untracked cache notifications

From: Christian Couder <christian.couder@gmail.com>
Date: Dec 24, 2015, 21:11 UTC
Message-ID: <CAP8UFD12kjUFvuaSMj3Q5sgDzCELejO7mEBuZ8g-=Cfa7sv5=A@mail.gmail.com>
In-Reply-To: <CACsJy8BQi8LQSHsZ7UMduCdE2_AeNwxn3kppc1xTfaNsMN=OXA@mail.gmail.com>

On Thu, Dec 24, 2015 at 11:01 AM, Duy Nguyen <pclouds@gmail.com> wrote:

Show 15 quoted lines

> On Thu, Dec 24, 2015 at 4:03 AM, Christian Couder
> <christian.couder@gmail.com> wrote:
>> @@ -1135,10 +1135,16 @@ int cmd_update_index(int argc, const char **argv, const char *prefix)
>>                 }
>>                 add_untracked_ident(the_index.untracked);
>>                 the_index.cache_changed |= UNTRACKED_CHANGED;
>> -       } else if (untracked_cache == UC_DISABLE && the_index.untracked) {
>> -               free_untracked_cache(the_index.untracked);
>> -               the_index.untracked = NULL;
>> -               the_index.cache_changed |= UNTRACKED_CHANGED;
>> +               if (verbose)
>> +                       printf(_("Untracked cache enabled for '%s'\n"), get_git_work_tree());
>
> Nit. If you use report(), then you can skip "if (verbose)" because
> it's done inside report().

Ok, will do.

Thanks, Christian.