git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 07/11] dir: add new_untracked_cache()

From
Christian Couder <christian.couder@gmail.com>
Date
Dec 23, 2015, 21:03 UTC
Message-ID
<1450904639-25592-8-git-send-email-chriscool@tuxfamily.org>
In-Reply-To
<1450904639-25592-1-git-send-email-chriscool@tuxfamily.org>
    Factor out code into new_untracked_cache(), which will be used
    multiple times in a later commit.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 dir.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/dir.c b/dir.c
index 0f7e293..4227ba6 100644
--- a/dir.c
+++ b/dir.c
@@ -1938,16 +1938,20 @@ void add_untracked_ident(struct untracked_cache *uc)
 	strbuf_addch(&uc->ident, 0);
 }
 
+static void new_untracked_cache(void)
+{
+	struct untracked_cache *uc = xcalloc(1, sizeof(*uc));
+	strbuf_init(&uc->ident, 100);
+	uc->exclude_per_dir = ".gitignore";
+	/* should be the same flags used by git-status */
+	uc->dir_flags = DIR_SHOW_OTHER_DIRECTORIES | DIR_HIDE_EMPTY_DIRECTORIES;
+	the_index.untracked = uc;
+}
+
 void add_untracked_cache(void)
 {
-	if (!the_index.untracked) {
-		struct untracked_cache *uc = xcalloc(1, sizeof(*uc));
-		strbuf_init(&uc->ident, 100);
-		uc->exclude_per_dir = ".gitignore";
-		/* should be the same flags used by git-status */
-		uc->dir_flags = DIR_SHOW_OTHER_DIRECTORIES | DIR_HIDE_EMPTY_DIRECTORIES;
-		the_index.untracked = uc;
-	}
+	if (!the_index.untracked)
+		new_untracked_cache();
 	add_untracked_ident(the_index.untracked);
 	the_index.cache_changed |= UNTRACKED_CHANGED;
 }
-- 
2.7.0.rc2.11.g68ccdd4
Previous: Christian CouderNext: Eric Sunshine
Message 10 of 18 in “Untracked cache improvements”
  1. 00/11 Untracked cache improvementsChristian Couder, Dec 23, 2015
  2. 01/11 dir: free untracked cache when removing itChristian Couder, Dec 23, 2015
  3. 02/11 update-index: use enum for untracked cache optionsChristian Couder, Dec 23, 2015
  4. 03/11 update-index: add --test-untracked-cacheChristian Couder, Dec 23, 2015
  5. 04/11 update-index: add untracked cache notificationsChristian Couder, Dec 23, 2015
  6. Duy NguyenDec 24, 2015
  7. Christian CouderDec 24, 2015
  8. 05/11 update-index: move 'uc' var declarationChristian Couder, Dec 23, 2015
  9. 06/11 dir: add add_untracked_cache()Christian Couder, Dec 23, 2015
  10. 07/11 dir: add new_untracked_cache()Christian Couder, Dec 23, 2015
  11. Eric SunshineDec 23, 2015
  12. Christian CouderDec 24, 2015
  13. 08/11 dir: add remove_untracked_cache()Christian Couder, Dec 23, 2015
  14. 09/11 dir: simplify untracked cache "ident" fieldChristian Couder, Dec 23, 2015
  15. 10/11 config: add core.untrackedCacheChristian Couder, Dec 23, 2015
  16. Duy NguyenDec 24, 2015
  17. Christian CouderDec 24, 2015
  18. 11/11 t7063: add tests for core.untrackedCacheChristian Couder, Dec 23, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.