Re: [PATCH v3 12/15] replay: disallow revision specific options and pathspecs

From: Christian Couder <christian.couder@gmail.com>
Date: Sep 7, 2023, 08:33 UTC
Message-ID: <CAP8UFD0iUGutbN7eLV2kmztXn5SjXMv47B7PTScE5d6sQoKgHw@mail.gmail.com>
In-Reply-To: <xmqqy1j3itdw.fsf@gitster.g>

On Tue, Jul 25, 2023 at 11:16 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

>
> Christian Couder <christian.couder@gmail.com> writes:
>
> > +     /*
> > +      * Reject any pathspec. (They are allowed and eaten by
> > +      * setup_revisions() above.) In the future we might accept
> > +      * them, after adding related tests and doc though.
> > +      */
> > +     if (revs.prune_data.nr) {
> > +             error(_("invalid pathspec: %s"), revs.prune_data.items[0].match);
>
> This made me waste a few minutes wondering if and how I misspelt my
> pathspec elements.  If we mean "no pathspec is allowed", we should
> say so instead.

Yeah, right. I have changed this to:

            error(_("no pathspec is allowed: '%s'"),
revs.prune_data.items[0].match);

> > +             usage_with_options(replay_usage, replay_options);
> > +     }