Re: [PATCH v5 00/14] Introduce new `git replay` command
- From
Elijah Newren <newren@gmail.com>
- Date
- Oct 30, 2023, 17:18 UTC
- Message-ID
- <CABPp-BGfsda-8CK7_YPJfhGMfpLqdDeB8X6wnqPAGmhiY4KjDA@mail.gmail.com>
- In-Reply-To
- <e04cfbdc-fd28-c645-8f5d-132f7ceec6be@gmx.de>
Hi Johannes,
On Sun, Oct 29, 2023 at 7:14 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 32 quoted lines
> > Hi Elijah, > > On Sat, 28 Oct 2023, Elijah Newren wrote: > > > On Tue, Oct 10, 2023 at 5:39 AM Christian Couder > > <christian.couder@gmail.com> wrote: > > > * Patch 12/15 (replay: disallow revision specific options and > > > pathspecs) in version 4 has been removed, so there are now only 14 > > > patches instead of 15 in the series. This follows a suggestion by > > > Dscho, and goes in the direction Elijah initially wanted before > > > Derrick Stolee argued for disallowing revision specific options and > > > pathspecs. > > > > [... snipping many parts that I agree with...] > > > > > Also instead of forcing reverse order we use the reverse order by > > > default but allow it to be changed using `--reverse`. Thanks to > > > Dscho. > > > > I can see why this might sometimes be useful for exclusively linear > > history, but it seems to open a can of worms and possibly unfixable > > corner cases for non-linear history. I'd rather not do this, or at > > least pull it out of this series and let us discuss it in some follow > > up series. There are some other alternatives that might handle such > > usecases better. > > I find myself wishing for an easy way to reverse commits, if only to > switch around the latest two commits while stopped during a rebase. > > So it would have been nice for me if there had been an easy, worktree-less > way to make that happen.
Seems reasonable; we'll definitely want to keep this in mind.
> I guess this would be going in the direction of reordering commits, > though, something we deliberately left for later?
Yes, I think that's a good framing for it.
Thanks, Elijah